Date: Wed, 4 Aug 1999 03:04:22 -0400
Message-Id: <199908040704.DAA13428@aleph.swift.xxx>
From: <swift@alum.mit.edu>
Subject: emacs20: mh-comp.el incompatible with nmh-1.0.1
To: submit@bugs.debian.org

Package: emacs20
Version: 20.3-10
Severity: normal

When using the mh-e system for email that comes with emacs20, there are
problems with replying to mail when you have nmh-1.0.1 installed.  I believe
the options to nmh's repl(1) are different than older versions of repl(1) that
were in MH.

When you respond to a mail in mh-e, you get a menu asking who you want the
reply to go to: "all", "to", or "from" (and "cc", the same as "all").  "from"
is the default if you hit <RET>.

The problem is that all responses behave as if you answered "from" (or simply
pressed <RET>).

I've patched mh-comp.el and give the diff below.  This works with nmh-1.0.1,
but probably it doesn't now work any more with older versions of MH.  So the
patch isn't the ideal one, probably.

Probably this bug & patch should be forwarded upstream to GNU, but I leave that
to you.


diff -c /usr/share/emacs/20.3/lisp/mail/mh-comp.el /var/tmp/mh-comp.el
*** /usr/share/emacs/20.3/lisp/mail/mh-comp.el	Sun Oct  4 12:54:38 1998
--- /var/tmp/mh-comp.el	Wed Aug  4 02:58:38 1999
***************
*** 141,151 ****
  is searched for first in the user's MH directory, then in the
  system MH lib directory.")
  
! (defvar mh-repl-formfile "replcomps"
!   "Name of file to be used as a skeleton for replying to messages.
! Default is \"replcomps\".  If not an absolute file name, the file
! is searched for first in the user's MH directory, then in the
! system MH lib directory.")
  
  ;;; Hooks:
  
--- 141,157 ----
  is searched for first in the user's MH directory, then in the
  system MH lib directory.")
  
! (defvar mh-repl-formfile nil
!   "A string value means use that file as a skeleton for sender-replying to messages.
! Nil means use default of \"replcomps\".  If not an absolute file
! name, the file is searched for first in the user's MH directory,
! then in the system MH lib directory.")
! 
! (defvar mh-repl-group-formfile nil
!   "A string value means use that file as a skeleton for group-replying to messages.
! Nil means use default of \"replgroupcomps\".  If not an absolute
! file name, the file is searched for first in the user's MH
! directory, then in the system MH lib directory.")
  
  ;;; Hooks:
  
***************
*** 402,409 ****
     from    sender only,
     to      sender and primary recipients,
     cc/all  sender and all recipients.
! If the file named by `mh-repl-formfile' exists, it is used as a skeleton
! for the reply.  See also documentation for `\\[mh-send]' function."
    (interactive (list (mh-get-msg-num t) current-prefix-arg))
    (let ((minibuffer-help-form
  	 "from => Sender only\nto => Sender and primary recipients\ncc or all => Sender and all recipients"))
--- 408,419 ----
     from    sender only,
     to      sender and primary recipients,
     cc/all  sender and all recipients.
! If the file named by `mh-repl-formfile' exists, it is used as a
! skeleton for replies to the sender only (\"from\"); if the file
! named by `mh-repl-group-formfile' exists, it is used as a
! skeleton for all other kinds of replies.
! 
! See also documentation for `\\[mh-send]' function."
    (interactive (list (mh-get-msg-num t) current-prefix-arg))
    (let ((minibuffer-help-form
  	 "from => Sender only\nto => Sender and primary recipients\ncc or all => Sender and all recipients"))
***************
*** 417,433 ****
  	  (config (current-window-configuration)))
        (message "Composing a reply...")
        (mh-exec-cmd "repl" "-build" "-noquery" "-nodraftfolder"
! 	     (if (stringp mh-repl-formfile) ;must be string, but we're paranoid
! 		 (list "-form" mh-repl-formfile))
! 	     mh-current-folder message
! 	     (cond ((or (equal reply-to "from") (equal reply-to ""))
! 		    '("-nocc" "all"))
! 		   ((equal reply-to "to")
! 		    '("-cc" "to"))
! 		   ((or (equal reply-to "cc") (equal reply-to "all"))
! 		    '("-cc" "all" "-nocc" "me")))
! 	     (if includep
! 		 '("-filter" "mhl.reply")))
        (let ((draft (mh-read-draft "reply"
  				  (expand-file-name "reply" mh-user-path)
  				  t)))
--- 427,441 ----
  	  (config (current-window-configuration)))
        (message "Composing a reply...")
        (mh-exec-cmd "repl" "-build" "-noquery" "-nodraftfolder"
! 		   mh-current-folder message
! 		   (cond ((or (equal reply-to "from") (equal reply-to ""))
! 			  "-nogroup")
! 			 ((equal reply-to "to")
! 			  '("-group" "-nocc" "cc" "-nocc" "me"))
! 			 ((or (equal reply-to "cc") (equal reply-to "all"))
! 			  '("-group" "-nocc" "me")))
! 		   (if includep
! 		       '("-filter" "mhl.reply")))
        (let ((draft (mh-read-draft "reply"
  				  (expand-file-name "reply" mh-user-path)
  				  t)))

Diff finished at Wed Aug  4 02:59:22


-- System Information
Debian Release: potato
Kernel Version: Linux aleph 2.0.36 #1 Fri Jan 15 18:12:05 EST 1999 i586 unknown

Versions of the packages emacs20 depends on:
ii  emacsen-common  1.4.9          Common facilities for all emacsen.
ii  libc6           2.1.2-0pre4    GNU C Library: Shared libraries and timezone
ii  liblockfile0    0.1-6          Shared library with NFS-safe locking functio
ii  libncurses4     4.2-3.2        Shared libraries for terminal handling
ii  xlib6g          3.3.3.1-10     shared libraries required by X clients