Report forwarded to debian-bugs-dist@lists.debian.org, Richard Braakman <dark@xs4all.nl>:
Bug#24429; Package ftplib3.   debian-bugs-dist@lists.debian.orgRichard Braakman  Subject: Bug#24429: ftplib prints perror msgs, and should check ftplib_debug first(patch included) Reply-To: Adam Heath , 24429@bugs.debian.org Resent-From: Adam Heath Resent-To: debian-bugs-dist@lists.debian.org Resent-CC: Richard Braakman Resent-Date: Sat, 11 Jul 1998 06:18:00 GMT Resent-Message-ID: Resent-Sender: iwj@debian.org X-Debian-PR-Message: report 24429 X-Debian-PR-Package: ftplib3 X-Debian-PR-Keywords: X-Loop: owner@bugs.debian.org Received: via spool by bugs@bugs.debian.org id=B.90013744311414 (code B ref -1); Sat, 11 Jul 1998 06:18:00 GMT Date: Sat, 11 Jul 1998 01:10:41 -0500 (CDT) From: Adam Heath X-Sender: adam@adam.hackers-net.com To: submit@bugs.debian.org Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Package: ftplib3 Version: 3.1-1 Severity: normal While writing a replacement ftp method for apt-get, and doing some testing, I changed the server to something non-existant. When ftplib tried to connect, it printed 'gethostbyname: success,' which will mess apt-get up(or at least cause confusion). The attached patch will only print perror() msgs when ftplib_debug > 1. Adam --- ftplib.c.orig Tue Jun 23 15:39:52 1998 +++ ftplib.c Sat Jul 11 00:53:38 1998 @@ -238,7 +238,7 @@ return retval; if ((x = net_read(ctl->handle,ctl->cput,ctl->cleft)) == -1) { - perror("read"); + if(ftplib_debug > 1) perror("read"); retval = -1; break; } @@ -323,7 +323,7 @@ char match[5]; if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -337,7 +337,7 @@ { if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -402,7 +402,7 @@ #else if ((pse = getservbyname("ftp","tcp")) == NULL) { - perror("getservbyname"); + if(ftplib_debug > 1) perror("getservbyname"); return 0; } sin.sin_port = pse->s_port; @@ -423,7 +423,7 @@ { if ((phe = gethostbyname(lhost)) == NULL) { - perror("gethostbyname"); + if(ftplib_debug > 1) perror("gethostbyname"); return 0; } memcpy((char *)&sin.sin_addr, phe->h_addr, phe->h_length); @@ -432,33 +432,33 @@ sControl = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP); if (sControl == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return 0; } if (setsockopt(sControl,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on, sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sControl); return 0; } if (connect(sControl, (struct sockaddr *)&sin, sizeof(sin)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sControl); return 0; } ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); return 0; } ctrl->buf = malloc(FTPLIB_BUFSIZ); if (ctrl->buf == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); free(ctrl); return 0; @@ -541,7 +541,7 @@ sprintf(buf,"%s\r\n",cmd); if (net_write(nControl->handle,buf,strlen(buf)) <= 0) { - perror("write"); + if(ftplib_debug > 1) perror("write"); return 0; } return readresp(expresp, nControl); @@ -625,27 +625,27 @@ { if (getsockname(nControl->handle, &sin.sa, &l) < 0) { - perror("getsockname"); + if(ftplib_debug > 1) perror("getsockname"); return 0; } } sData = socket(PF_INET,SOCK_STREAM,IPPROTO_TCP); if (sData == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on,sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_LINGER, SETSOCKOPT_OPTVAL_TYPE &lng,sizeof(lng)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } @@ -653,7 +653,7 @@ { if (connect(sData, &sin.sa, sizeof(sin.sa)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sData); return -1; } @@ -663,13 +663,13 @@ sin.in.sin_port = 0; if (bind(sData, &sin.sa, sizeof(sin)) == -1) { - perror("bind"); + if(ftplib_debug > 1) perror("bind"); net_close(sData); return 0; } if (listen(sData, 1) < 0) { - perror("listen"); + if(ftplib_debug > 1) perror("listen"); net_close(sData); return 0; } @@ -691,13 +691,13 @@ ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); return -1; } if ((mode == 'A') && ((ctrl->buf = malloc(FTPLIB_BUFSIZ)) == NULL)) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); free(ctrl); return -1; @@ -1104,7 +1104,7 @@ while ((l = FtpRead(dbuf, FTPLIB_BUFSIZ, nData)) > 0) if (fwrite(dbuf, 1, l, local) <= 0) { - perror("localfile write"); + if(ftplib_debug > 1) perror("localfile write"); break; } } ---   Acknowledgement sent to Adam Heath <adam.heath@usa.net>:
New bug report received and forwarded. Copy sent to Richard Braakman <dark@xs4all.nl>.   -t  From: owner@bugs.debian.org (Ian Jackson) To: Adam Heath Subject: Bug#24429: Acknowledgement (ftplib prints perror msgs, and should check ftplib_debug first(patch included)) Message-ID: In-Reply-To: References: X-Debian-PR-Message: ack 24429 Thank you for the problem report you have sent regarding Debian. This is an automatically generated reply, to let you know your message has been received. It is being forwarded to the developers' mailing list for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): Richard Braakman If you wish to submit further information on your problem, please send it to 24429@bugs.debian.org (and *not* to bugs@bugs.debian.org). Please do not reply to the address at the top of this message, unless you wish to report a problem with the bug-tracking system. Ian Jackson (administrator, Debian bugs database)   Received: (at submit) by bugs.debian.org; 11 Jul 1998 06:10:43 +0000 Received: (qmail 11411 invoked from network); 11 Jul 1998 06:10:42 -0000 Received: from dalasc7-72.flash.net (HELO adam.hackers-net.com) (mail@209.30.166.72) by debian.novare.net with SMTP; 11 Jul 1998 06:10:42 -0000 Received: from adam.hackers-net.com [192.168.0.3] (adam) by adam.hackers-net.com with smtp (Exim 1.92 #1 (Debian)) id 0yusrp-00024W-00; Sat, 11 Jul 1998 01:10:41 -0500 Date: Sat, 11 Jul 1998 01:10:41 -0500 (CDT) From: Adam Heath X-Sender: adam@adam.hackers-net.com Reply-To: Adam Heath To: submit@bugs.debian.org Subject: ftplib prints perror msgs, and should check ftplib_debug first(patch included) Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Package: ftplib3 Version: 3.1-1 Severity: normal While writing a replacement ftp method for apt-get, and doing some testing, I changed the server to something non-existant. When ftplib tried to connect, it printed 'gethostbyname: success,' which will mess apt-get up(or at least cause confusion). The attached patch will only print perror() msgs when ftplib_debug > 1. Adam --- ftplib.c.orig Tue Jun 23 15:39:52 1998 +++ ftplib.c Sat Jul 11 00:53:38 1998 @@ -238,7 +238,7 @@ return retval; if ((x = net_read(ctl->handle,ctl->cput,ctl->cleft)) == -1) { - perror("read"); + if(ftplib_debug > 1) perror("read"); retval = -1; break; } @@ -323,7 +323,7 @@ char match[5]; if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -337,7 +337,7 @@ { if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -402,7 +402,7 @@ #else if ((pse = getservbyname("ftp","tcp")) == NULL) { - perror("getservbyname"); + if(ftplib_debug > 1) perror("getservbyname"); return 0; } sin.sin_port = pse->s_port; @@ -423,7 +423,7 @@ { if ((phe = gethostbyname(lhost)) == NULL) { - perror("gethostbyname"); + if(ftplib_debug > 1) perror("gethostbyname"); return 0; } memcpy((char *)&sin.sin_addr, phe->h_addr, phe->h_length); @@ -432,33 +432,33 @@ sControl = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP); if (sControl == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return 0; } if (setsockopt(sControl,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on, sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sControl); return 0; } if (connect(sControl, (struct sockaddr *)&sin, sizeof(sin)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sControl); return 0; } ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); return 0; } ctrl->buf = malloc(FTPLIB_BUFSIZ); if (ctrl->buf == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); free(ctrl); return 0; @@ -541,7 +541,7 @@ sprintf(buf,"%s\r\n",cmd); if (net_write(nControl->handle,buf,strlen(buf)) <= 0) { - perror("write"); + if(ftplib_debug > 1) perror("write"); return 0; } return readresp(expresp, nControl); @@ -625,27 +625,27 @@ { if (getsockname(nControl->handle, &sin.sa, &l) < 0) { - perror("getsockname"); + if(ftplib_debug > 1) perror("getsockname"); return 0; } } sData = socket(PF_INET,SOCK_STREAM,IPPROTO_TCP); if (sData == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on,sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_LINGER, SETSOCKOPT_OPTVAL_TYPE &lng,sizeof(lng)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } @@ -653,7 +653,7 @@ { if (connect(sData, &sin.sa, sizeof(sin.sa)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sData); return -1; } @@ -663,13 +663,13 @@ sin.in.sin_port = 0; if (bind(sData, &sin.sa, sizeof(sin)) == -1) { - perror("bind"); + if(ftplib_debug > 1) perror("bind"); net_close(sData); return 0; } if (listen(sData, 1) < 0) { - perror("listen"); + if(ftplib_debug > 1) perror("listen"); net_close(sData); return 0; } @@ -691,13 +691,13 @@ ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); return -1; } if ((mode == 'A') && ((ctrl->buf = malloc(FTPLIB_BUFSIZ)) == NULL)) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); free(ctrl); return -1; @@ -1104,7 +1104,7 @@ while ((l = FtpRead(dbuf, FTPLIB_BUFSIZ, nData)) > 0) if (fwrite(dbuf, 1, l, local) <= 0) { - perror("localfile write"); + if(ftplib_debug > 1) perror("localfile write"); break; } } ---   Reply sent to Richard Braakman <dark@xs4all.nl>:
You have marked bug as forwarded.   -t  From: owner@bugs.debian.org (Ian Jackson) To: Richard Braakman Bcc: debian-bugs-forwarded@lists.debian.org Subject: Bug#24429: marked as forwarded (ftplib prints perror msgs, and should check ftplib_debug first(patch included)) Message-ID: In-Reply-To: References: X-Debian-PR-Message: forwarded 24429 Your message dated Sat, 11 Jul 1998 10:49:02 +0200 (CEST) with message-id and subject line ftplib prints perror messages, should check ftplib_debug first has caused the Debian bug report #24429, regarding ftplib prints perror msgs, and should check ftplib_debug first(patch included) to be marked as having been forwarded to the upstream software author(s) pfau@cnj.digex.net. (NB: If you are a system administrator and have no idea what I'm talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Ian Jackson (administrator, Debian bugs database) Received: (at submit) by bugs.debian.org; 11 Jul 1998 06:10:43 +0000 Received: (qmail 11411 invoked from network); 11 Jul 1998 06:10:42 -0000 Received: from dalasc7-72.flash.net (HELO adam.hackers-net.com) (mail@209.30.166.72) by debian.novare.net with SMTP; 11 Jul 1998 06:10:42 -0000 Received: from adam.hackers-net.com [192.168.0.3] (adam) by adam.hackers-net.com with smtp (Exim 1.92 #1 (Debian)) id 0yusrp-00024W-00; Sat, 11 Jul 1998 01:10:41 -0500 Date: Sat, 11 Jul 1998 01:10:41 -0500 (CDT) From: Adam Heath X-Sender: adam@adam.hackers-net.com Reply-To: Adam Heath To: submit@bugs.debian.org Subject: ftplib prints perror msgs, and should check ftplib_debug first(patch included) Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Package: ftplib3 Version: 3.1-1 Severity: normal While writing a replacement ftp method for apt-get, and doing some testing, I changed the server to something non-existant. When ftplib tried to connect, it printed 'gethostbyname: success,' which will mess apt-get up(or at least cause confusion). The attached patch will only print perror() msgs when ftplib_debug > 1. Adam --- ftplib.c.orig Tue Jun 23 15:39:52 1998 +++ ftplib.c Sat Jul 11 00:53:38 1998 @@ -238,7 +238,7 @@ return retval; if ((x = net_read(ctl->handle,ctl->cput,ctl->cleft)) == -1) { - perror("read"); + if(ftplib_debug > 1) perror("read"); retval = -1; break; } @@ -323,7 +323,7 @@ char match[5]; if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -337,7 +337,7 @@ { if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -402,7 +402,7 @@ #else if ((pse = getservbyname("ftp","tcp")) == NULL) { - perror("getservbyname"); + if(ftplib_debug > 1) perror("getservbyname"); return 0; } sin.sin_port = pse->s_port; @@ -423,7 +423,7 @@ { if ((phe = gethostbyname(lhost)) == NULL) { - perror("gethostbyname"); + if(ftplib_debug > 1) perror("gethostbyname"); return 0; } memcpy((char *)&sin.sin_addr, phe->h_addr, phe->h_length); @@ -432,33 +432,33 @@ sControl = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP); if (sControl == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return 0; } if (setsockopt(sControl,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on, sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sControl); return 0; } if (connect(sControl, (struct sockaddr *)&sin, sizeof(sin)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sControl); return 0; } ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); return 0; } ctrl->buf = malloc(FTPLIB_BUFSIZ); if (ctrl->buf == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); free(ctrl); return 0; @@ -541,7 +541,7 @@ sprintf(buf,"%s\r\n",cmd); if (net_write(nControl->handle,buf,strlen(buf)) <= 0) { - perror("write"); + if(ftplib_debug > 1) perror("write"); return 0; } return readresp(expresp, nControl); @@ -625,27 +625,27 @@ { if (getsockname(nControl->handle, &sin.sa, &l) < 0) { - perror("getsockname"); + if(ftplib_debug > 1) perror("getsockname"); return 0; } } sData = socket(PF_INET,SOCK_STREAM,IPPROTO_TCP); if (sData == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on,sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_LINGER, SETSOCKOPT_OPTVAL_TYPE &lng,sizeof(lng)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } @@ -653,7 +653,7 @@ { if (connect(sData, &sin.sa, sizeof(sin.sa)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sData); return -1; } @@ -663,13 +663,13 @@ sin.in.sin_port = 0; if (bind(sData, &sin.sa, sizeof(sin)) == -1) { - perror("bind"); + if(ftplib_debug > 1) perror("bind"); net_close(sData); return 0; } if (listen(sData, 1) < 0) { - perror("listen"); + if(ftplib_debug > 1) perror("listen"); net_close(sData); return 0; } @@ -691,13 +691,13 @@ ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); return -1; } if ((mode == 'A') && ((ctrl->buf = malloc(FTPLIB_BUFSIZ)) == NULL)) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); free(ctrl); return -1; @@ -1104,7 +1104,7 @@ while ((l = FtpRead(dbuf, FTPLIB_BUFSIZ, nData)) > 0) if (fwrite(dbuf, 1, l, local) <= 0) { - perror("localfile write"); + if(ftplib_debug > 1) perror("localfile write"); break; } } ---   Received: (at 24429-forwarded) by bugs.debian.org; 11 Jul 1998 08:47:07 +0000 Received: (qmail 15181 invoked from network); 11 Jul 1998 08:47:07 -0000 Received: from smtp1.xs4all.nl (194.109.6.51) by debian.novare.net with SMTP; 11 Jul 1998 08:47:07 -0000 Received: from harte.xs4all.nl (root@harte.xs4all.nl [194.109.63.66]) by smtp1.xs4all.nl (8.8.8/8.8.8) with ESMTP id KAA00669; Sat, 11 Jul 1998 10:47:03 +0200 (CEST) Received: from night (mail@night.xs4all.nl [192.168.2.2]) by harte.xs4all.nl (8.8.8/8.8.8/Debian/GNU) with ESMTP id KAA30016; Sat, 11 Jul 1998 10:46:16 +0200 Received: from dark by night with local (Exim 1.92 #1 (Debian)) id 0yuvL4-0000kZ-00; Sat, 11 Jul 1998 10:49:02 +0200 Subject: ftplib prints perror messages, should check ftplib_debug first To: pfau@cnj.digex.net Date: Sat, 11 Jul 1998 10:49:02 +0200 (CEST) Cc: adam.heath@usa.net, 24429-forwarded@bugs.debian.org X-Mailer: ELM [version 2.4ME+ PL39 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: From: Richard Braakman Greetings. I received this bugreport for the Debian package of ftplib 3.1. I'll quote it here and add my comments after it. > Subject: Bug#24429: ftplib prints perror msgs, and should check ftplib_debug first(patch included) > Reply-To: Adam Heath , 24429@bugs.debian.org > Date: Sat, 11 Jul 1998 01:10:41 -0500 (CDT) > To: submit@bugs.debian.org > > Package: ftplib3 > Version: 3.1-1 > Severity: normal > > While writing a replacement ftp method for apt-get, and doing some testing, I > changed the server to something non-existant. When ftplib tried to connect, > it printed 'gethostbyname: success,' which will mess apt-get up(or at least > cause confusion). The attached patch will only print perror() msgs when > ftplib_debug > 1. > > Adam The report mentions "apt-get". This is part of our new package management interface. It uses modules ("methods") to access packages by various means, one of which is ftp. The output generated by those methods is part of the interface with apt-get, so it is important that they have control over their own error reporting. I wondered why perror() would print "success" after something had gone wrong, and I checked the man page for gethostbyname(): --------------- RETURN VALUE The gethostbyname() and gethostbyaddr() functions return the hostent structure or a NULL pointer if an error occurs. On error, the h_errno variable holds an error number. --------------- So that bit of code probably needs an additional patch to check h_errno and output an appropriate message, rather than using perror(). The "Version 3.1-1" means that his report is about the first Debian package based on ftplib 3.1. Please preserve the Cc to 24429-forwarded@bugs.debian.org in your replies, so that this discussion is archived together with the bug report. Thanks, Richard Braakman Adam's patch follows: --- ftplib.c.orig Tue Jun 23 15:39:52 1998 +++ ftplib.c Sat Jul 11 00:53:38 1998 @@ -238,7 +238,7 @@ return retval; if ((x = net_read(ctl->handle,ctl->cput,ctl->cleft)) == -1) { - perror("read"); + if(ftplib_debug > 1) perror("read"); retval = -1; break; } @@ -323,7 +323,7 @@ char match[5]; if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -337,7 +337,7 @@ { if (readline(nControl->response,256,nControl) == -1) { - perror("Control socket read failed"); + if(ftplib_debug > 1) perror("Control socket read failed"); return 0; } if (ftplib_debug > 1) @@ -402,7 +402,7 @@ #else if ((pse = getservbyname("ftp","tcp")) == NULL) { - perror("getservbyname"); + if(ftplib_debug > 1) perror("getservbyname"); return 0; } sin.sin_port = pse->s_port; @@ -423,7 +423,7 @@ { if ((phe = gethostbyname(lhost)) == NULL) { - perror("gethostbyname"); + if(ftplib_debug > 1) perror("gethostbyname"); return 0; } memcpy((char *)&sin.sin_addr, phe->h_addr, phe->h_length); @@ -432,33 +432,33 @@ sControl = socket(PF_INET, SOCK_STREAM, IPPROTO_TCP); if (sControl == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return 0; } if (setsockopt(sControl,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on, sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sControl); return 0; } if (connect(sControl, (struct sockaddr *)&sin, sizeof(sin)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sControl); return 0; } ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); return 0; } ctrl->buf = malloc(FTPLIB_BUFSIZ); if (ctrl->buf == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sControl); free(ctrl); return 0; @@ -541,7 +541,7 @@ sprintf(buf,"%s\r\n",cmd); if (net_write(nControl->handle,buf,strlen(buf)) <= 0) { - perror("write"); + if(ftplib_debug > 1) perror("write"); return 0; } return readresp(expresp, nControl); @@ -625,27 +625,27 @@ { if (getsockname(nControl->handle, &sin.sa, &l) < 0) { - perror("getsockname"); + if(ftplib_debug > 1) perror("getsockname"); return 0; } } sData = socket(PF_INET,SOCK_STREAM,IPPROTO_TCP); if (sData == -1) { - perror("socket"); + if(ftplib_debug > 1) perror("socket"); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_REUSEADDR, SETSOCKOPT_OPTVAL_TYPE &on,sizeof(on)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } if (setsockopt(sData,SOL_SOCKET,SO_LINGER, SETSOCKOPT_OPTVAL_TYPE &lng,sizeof(lng)) == -1) { - perror("setsockopt"); + if(ftplib_debug > 1) perror("setsockopt"); net_close(sData); return -1; } @@ -653,7 +653,7 @@ { if (connect(sData, &sin.sa, sizeof(sin.sa)) == -1) { - perror("connect"); + if(ftplib_debug > 1) perror("connect"); net_close(sData); return -1; } @@ -663,13 +663,13 @@ sin.in.sin_port = 0; if (bind(sData, &sin.sa, sizeof(sin)) == -1) { - perror("bind"); + if(ftplib_debug > 1) perror("bind"); net_close(sData); return 0; } if (listen(sData, 1) < 0) { - perror("listen"); + if(ftplib_debug > 1) perror("listen"); net_close(sData); return 0; } @@ -691,13 +691,13 @@ ctrl = calloc(1,sizeof(netbuf)); if (ctrl == NULL) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); return -1; } if ((mode == 'A') && ((ctrl->buf = malloc(FTPLIB_BUFSIZ)) == NULL)) { - perror("calloc"); + if(ftplib_debug > 1) perror("calloc"); net_close(sData); free(ctrl); return -1; @@ -1104,7 +1104,7 @@ while ((l = FtpRead(dbuf, FTPLIB_BUFSIZ, nData)) > 0) if (fwrite(dbuf, 1, l, local) <= 0) { - perror("localfile write"); + if(ftplib_debug > 1) perror("localfile write"); break; } } ---   Received: (at 24429-forwarded) by bugs.debian.org; 11 Jul 1998 12:48:54 +0000 Received: (qmail 31804 invoked from network); 11 Jul 1998 12:48:53 -0000 Received: from kona.digex.net (root@199.125.134.32) by debian.novare.net with SMTP; 11 Jul 1998 12:48:53 -0000 Received: from cnj.digex.net (pfau@kona.digex.net [199.125.134.32]) by kona.digex.net (8.8.5/8.6.9) with ESMTP id IAA00215; Sat, 11 Jul 1998 08:47:15 -0400 Sender: pfau@cnj.digex.net Message-ID: <35A75ED3.86E4D881@cnj.digex.net> Date: Sat, 11 Jul 1998 08:47:15 -0400 From: Thomas Pfau Organization: exDEC X-Mailer: Mozilla 4.04 [en] (X11; I; Linux 2.0.29 i486) MIME-Version: 1.0 To: Richard Braakman CC: 24429-forwarded@bugs.debian.org Subject: Re: ftplib prints perror messages, should check ftplib_debug first References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Thanks for the bug report and the patch. I'll look them over. There were some problems with the documentation on 3.1 and I found a bug in qftp so a new release will be out shortly. -- tom_p pfau@cnj.digex.net http://www.cnj.digex.net/~pfau Community Gospel Church information at http://www.cnj.digex.net/~pfau/cgc/   Information forwarded to debian-bugs-dist@lists.debian.org, Richard Braakman <dark@xs4all.nl>:
Bug#24429; Package ftplib3.   debian-bugs-dist@lists.debian.orgRichard Braakman  Subject: Bug#24429: ftplib prints perror msgs, and should check ftplib_debug first(patch included) Reply-To: Manoj Srivastava , 24429@bugs.debian.org Resent-From: Manoj Srivastava Orignal-Sender: srivasta@datasync.com Resent-To: debian-bugs-dist@lists.debian.org Resent-CC: Richard Braakman Resent-Date: Sun, 12 Jul 1998 14:48:00 GMT Resent-Message-ID: Resent-Sender: iwj@debian.org X-Debian-PR-Message: report 24429 X-Debian-PR-Package: ftplib3 X-Debian-PR-Keywords: X-Loop: owner@bugs.debian.org Received: via spool by 24429-bugs@bugs.debian.org id=B24429.90025428814622 (code B ref 24429); Sun, 12 Jul 1998 14:48:00 GMT Sender: srivasta@datasync.com X-Time: Sun Jul 12 09:28:09 1998 X-Mail-System: Vm 6.53 for GNU Emacs 19.34.1 Organization: Manoj Srivastava's Home To: Adam Heath Cc: 24429@bugs.debian.org References: Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII From: Manoj Srivastava Date: 12 Jul 1998 09:28:14 -0500 In-Reply-To: Adam Heath's message of "Sat, 11 Jul 1998 01:10:41 -0500 (CDT)" Message-ID: <87zpef6t4x.fsf@tiamat.datasync.com> Lines: 26 X-Mailer: Gnus v5.6.23/Emacs 19.34 Hi, Umm, at least some of the perror messages should also be sent to apt as E: (error) messages, I think. "Control socket read failed" is something I think should bubble up, don't you? In fact, most messages should buble up to apt, especially if the library aborts and performs a return 0. I think the library should not be talking stderr/stdout directly, but nither should it be just returning with no indication of what went wrong. I think the library should have an error value return; it should return a non-zero value; something that maps to a standard error number, or else it could create its own int return values that people can lookup in a table. This may be a lot of work; but IMHO is a better design. Please treat this as a wishlist. manoj -- If you think the United States has stood still, who built the largest shopping center in the world? Richard M. Nixon Manoj Srivastava Key C7261095 fingerprint = CB D9 F4 12 68 07 E4 05 CC 2D 27 12 1D F5 E8 6E   Acknowledgement sent to Manoj Srivastava <srivasta@datasync.com>:
Extra info received and forwarded to list. Copy sent to Richard Braakman <dark@xs4all.nl>.   -t  From: owner@bugs.debian.org (Ian Jackson) To: Manoj Srivastava Subject: Bug#24429: Info received (was Bug#24429: ftplib prints perror msgs, and should check ftplib_debug first(patch included)) Message-ID: In-Reply-To: <87zpef6t4x.fsf@tiamat.datasync.com> References: <87zpef6t4x.fsf@tiamat.datasync.com> X-Debian-PR-Message: ack-info-maintonly 24429 Thank you for the additional information you have supplied regarding this problem report. It has been forwarded to the developer(s) and to the developers' mailing list to accompany the original report. Your message has been sent to the package maintainer(s): Richard Braakman If you wish to continue to submit further information on your problem, please send it to 24429@bugs.debian.org, as before. Please do not reply to the address at the top of this message, unless you wish to report a problem with the bug-tracking system. Ian Jackson (administrator, Debian bugs database)   Received: (at 24429) by bugs.debian.org; 12 Jul 1998 14:38:08 +0000 Received: (qmail 14619 invoked from network); 12 Jul 1998 14:38:06 -0000 Received: from tiamat.datasync.com (root@206.96.246.252) by debian.novare.net with SMTP; 12 Jul 1998 14:38:06 -0000 Received: (from srivasta@localhost) by tiamat.datasync.com (8.9.1/8.9.1/Debian/GNU) id JAA31126; Sun, 12 Jul 1998 09:28:22 -0500 Sender: srivasta@datasync.com X-Time: Sun Jul 12 09:28:09 1998 X-Mail-System: Vm 6.53 for GNU Emacs 19.34.1 Organization: Manoj Srivastava's Home To: Adam Heath Cc: 24429@bugs.debian.org Subject: Re: Bug#24429: ftplib prints perror msgs, and should check ftplib_debug first(patch included) References: Mime-Version: 1.0 (generated by tm-edit 7.106) Content-Type: text/plain; charset=US-ASCII From: Manoj Srivastava Date: 12 Jul 1998 09:28:14 -0500 In-Reply-To: Adam Heath's message of "Sat, 11 Jul 1998 01:10:41 -0500 (CDT)" Message-ID: <87zpef6t4x.fsf@tiamat.datasync.com> Lines: 26 X-Mailer: Gnus v5.6.23/Emacs 19.34 Hi, Umm, at least some of the perror messages should also be sent to apt as E: (error) messages, I think. "Control socket read failed" is something I think should bubble up, don't you? In fact, most messages should buble up to apt, especially if the library aborts and performs a return 0. I think the library should not be talking stderr/stdout directly, but nither should it be just returning with no indication of what went wrong. I think the library should have an error value return; it should return a non-zero value; something that maps to a standard error number, or else it could create its own int return values that people can lookup in a table. This may be a lot of work; but IMHO is a better design. Please treat this as a wishlist. manoj -- If you think the United States has stood still, who built the largest shopping center in the world? Richard M. Nixon Manoj Srivastava Key C7261095 fingerprint = CB D9 F4 12 68 07 E4 05 CC 2D 27 12 1D F5 E8 6E   Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#24429; Package ftplib3.   debian-bugs-dist@lists.debian.org  Subject: Bug#24429: Reply from author Reply-To: Richard Braakman , 24429@bugs.debian.org Resent-From: Richard Braakman Resent-To: debian-bugs-dist@lists.debian.org Resent-Date: Tue, 14 Jul 1998 10:33:02 GMT Resent-Message-ID: Resent-Sender: iwj@debian.org X-Debian-PR-Message: report 24429 X-Debian-PR-Package: ftplib3 X-Debian-PR-Keywords: X-Loop: owner@bugs.debian.org Received: via spool by 24429-bugs@bugs.debian.org id=B24429.90041181827667 (code B ref 24429); Tue, 14 Jul 1998 10:33:02 GMT To: 24429@bugs.debian.org Date: Tue, 14 Jul 1998 12:22:43 +0200 (CEST) Cc: 24429-submitter@bugs.debian.org X-Mailer: ELM [version 2.4ME+ PL39 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: From: Richard Braakman I got the following reply from the author: > I'll fix up the perror's and other accesses to stdout/stderr and look into > a way to get the actual error codes back to the user. Thanks.   Acknowledgement sent to Richard Braakman <dark@xs4all.nl>:
Extra info received and forwarded to list.   -t  From: owner@bugs.debian.org (Ian Jackson) To: Richard Braakman Subject: Bug#24429: Info received (was Reply from author) Message-ID: In-Reply-To: References: X-Debian-PR-Message: ack-info-maintonly 24429 Thank you for the additional information you have supplied regarding this problem report. It has been forwarded to the developer(s) and to the developers' mailing list to accompany the original report. If you wish to continue to submit further information on your problem, please send it to 24429@bugs.debian.org, as before. Please do not reply to the address at the top of this message, unless you wish to report a problem with the bug-tracking system. Ian Jackson (administrator, Debian bugs database)   Received: (at 24429) by bugs.debian.org; 14 Jul 1998 10:23:38 +0000 Received: (qmail 27660 invoked from network); 14 Jul 1998 10:23:38 -0000 Received: from smtp1.xs4all.nl (194.109.6.51) by debian.novare.net with SMTP; 14 Jul 1998 10:23:38 -0000 Received: from harte.xs4all.nl (root@harte.xs4all.nl [194.109.63.66]) by smtp1.xs4all.nl (8.8.8/8.8.8) with ESMTP id MAA24312; Tue, 14 Jul 1998 12:23:35 +0200 (CEST) Received: from night (mail@night.xs4all.nl [192.168.2.2]) by harte.xs4all.nl (8.8.8/8.8.8/Debian/GNU) with ESMTP id MAA27748; Tue, 14 Jul 1998 12:19:59 +0200 Received: from dark by night with local (Exim 1.92 #1 (Debian)) id 0yw2EN-0001Ek-00; Tue, 14 Jul 1998 12:22:43 +0200 Subject: Reply from author To: 24429@bugs.debian.org Date: Tue, 14 Jul 1998 12:22:43 +0200 (CEST) Cc: 24429-submitter@bugs.debian.org X-Mailer: ELM [version 2.4ME+ PL39 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: From: Richard Braakman I got the following reply from the author: > I'll fix up the perror's and other accesses to stdout/stderr and look into > a way to get the actual error codes back to the user. Thanks.   Message sent on to Adam Heath <adam.heath@usa.net>:
Bug#24429.   Adam Heath  Subject: Bug#24429: Reply from author Reply-To: Richard Braakman , 24429-quiet@bugs.debian.org Resent-To: Adam Heath Resent-Date: Tue, 14 Jul 1998 10:33:05 GMT Resent-Message-ID: Resent-Sender: iwj@debian.org X-Debian-PR-Message: report 24429 X-Debian-PR-Package: ftplib3 X-Debian-PR-Keywords: X-Loop: owner@bugs.debian.org Received: via spool by 24429-submitter@bugs.debian.org id=U24429.90041181827669 (code U ref 24429); Tue, 14 Jul 1998 10:33:05 GMT To: 24429@bugs.debian.org Date: Tue, 14 Jul 1998 12:22:43 +0200 (CEST) Cc: 24429-submitter@bugs.debian.org X-Mailer: ELM [version 2.4ME+ PL39 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: From: Richard Braakman I got the following reply from the author: > I'll fix up the perror's and other accesses to stdout/stderr and look into > a way to get the actual error codes back to the user. Thanks.   Received: (at 24429-submitter) by bugs.debian.org; 14 Jul 1998 10:23:38 +0000 Received: (qmail 27660 invoked from network); 14 Jul 1998 10:23:38 -0000 Received: from smtp1.xs4all.nl (194.109.6.51) by debian.novare.net with SMTP; 14 Jul 1998 10:23:38 -0000 Received: from harte.xs4all.nl (root@harte.xs4all.nl [194.109.63.66]) by smtp1.xs4all.nl (8.8.8/8.8.8) with ESMTP id MAA24312; Tue, 14 Jul 1998 12:23:35 +0200 (CEST) Received: from night (mail@night.xs4all.nl [192.168.2.2]) by harte.xs4all.nl (8.8.8/8.8.8/Debian/GNU) with ESMTP id MAA27748; Tue, 14 Jul 1998 12:19:59 +0200 Received: from dark by night with local (Exim 1.92 #1 (Debian)) id 0yw2EN-0001Ek-00; Tue, 14 Jul 1998 12:22:43 +0200 Subject: Reply from author To: 24429@bugs.debian.org Date: Tue, 14 Jul 1998 12:22:43 +0200 (CEST) Cc: 24429-submitter@bugs.debian.org X-Mailer: ELM [version 2.4ME+ PL39 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: From: Richard Braakman I got the following reply from the author: > I'll fix up the perror's and other accesses to stdout/stderr and look into > a way to get the actual error codes back to the user. Thanks.   Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#24429; Package ftplib3.   debian-bugs-dist@lists.debian.org  Subject: Bug#24429: Not fixed Reply-To: Richard Braakman , 24429@bugs.debian.org Resent-From: Richard Braakman Orignal-Sender: Richard Braakman Resent-To: debian-bugs-dist@lists.debian.org Resent-Date: Tue, 27 Mar 2001 19:16:16 GMT Resent-Message-ID: Resent-Sender: owner@bugs.debian.org X-Debian-PR-Message: report 24429 X-Debian-PR-Package: ftplib3 X-Debian-PR-Keywords: X-Loop: owner@bugs.debian.org Received: via spool by 24429-bugs@bugs.debian.org id=B24429.98571984624586 (code B ref 24429); Tue, 27 Mar 2001 19:16:16 GMT Date: Tue, 27 Mar 2001 22:04:02 +0300 From: Richard Braakman To: 24429@bugs.debian.org Message-ID: <20010327220402.A1321@cs140102.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.15i Sender: Richard Braakman Delivered-To: 24429@bugs.debian.org I'd like to add that the author did release a new version of ftplib, but without fixing this problem. I suspect he didn't like the provided patch for the same reasons that Manoj described, and didn't have time to create a full error-reporting framework for the library. Richard Braakman   Acknowledgement sent to Richard Braakman <dark@xs4all.nl>:
Extra info received and forwarded to list.   -t  From: owner@bugs.debian.org (Debian Bug Tracking System) To: Richard Braakman Subject: Bug#24429: Info received (was Not fixed) Message-ID: In-Reply-To: <20010327220402.A1321@cs140102.pp.htv.fi> References: <20010327220402.A1321@cs140102.pp.htv.fi> X-Debian-PR-Message: ack-info-maintonly 24429 Thank you for the additional information you have supplied regarding this problem report. It has been forwarded to the developer(s) and to the developers mailing list to accompany the original report. If you wish to continue to submit further information on your problem, please send it to 24429@bugs.debian.org, as before. Please do not reply to the address at the top of this message, unless you wish to report a problem with the Bug-tracking system. Darren Benham (administrator, Debian Bugs database)   Received: (at 24429) by bugs.debian.org; 27 Mar 2001 19:04:06 +0000 From dark@cs140102.pp.htv.fi Tue Mar 27 13:04:06 2001 Return-path: Received: from m2ep.pp.htv.fi (m2.pp.htv.fi) [212.90.64.98] by master.debian.org with esmtp (Exim 3.12 1 (Debian)) id 14hylB-0006I0-00; Tue, 27 Mar 2001 13:04:06 -0600 Received: from m7.pp.htv.fi (m7.pp.htv.fi [212.90.64.22]) by m2.pp.htv.fi (8.9.3 (PHNE_22672)/8.8.6) with ESMTP id WAA06327 for <24429@bugs.debian.org>; Tue, 27 Mar 2001 22:03:34 +0300 (EETDST) Received: from night (cs140102.pp.htv.fi [213.243.140.102]) by m7.pp.htv.fi (8.8.6 (PHNE_14041)/8.8.6) with ESMTP id VAA18909 for <24429@bugs.debian.org>; Tue, 27 Mar 2001 21:03:33 +0200 (EET) Received: from dark by night with local (Exim 3.12 #1 (Debian)) id 14hyl8-0000LV-00 for <24429@bugs.debian.org>; Tue, 27 Mar 2001 22:04:02 +0300 Date: Tue, 27 Mar 2001 22:04:02 +0300 From: Richard Braakman To: 24429@bugs.debian.org Subject: Not fixed Message-ID: <20010327220402.A1321@cs140102.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.15i Sender: Richard Braakman Delivered-To: 24429@bugs.debian.org I'd like to add that the author did release a new version of ftplib, but without fixing this problem. I suspect he didn't like the provided patch for the same reasons that Manoj described, and didn't have time to create a full error-reporting framework for the library. Richard Braakman   Changed Bug title. Request was from Matej Vela <vela@debian.org> to control@bugs.debian.org.   Received: (at control) by bugs.debian.org; 8 Mar 2006 07:00:03 +0000 From mvela@irb.hr Tue Mar 07 23:00:03 2006 Return-path: Received: from mail.irb.hr ([161.53.22.8] ident=UNKNOWN) by spohr.debian.org with esmtp (Exim 4.50) id 1FGseR-0006GV-Ap for control@bugs.debian.org; Tue, 07 Mar 2006 23:00:03 -0800 Received: from diziet.irb.hr (diziet.irb.hr [161.53.22.31]) by mail.irb.hr (8.13.4/8.13.4/Debian-3) with ESMTP id k286xjtZ006746 for ; Wed, 8 Mar 2006 07:59:45 +0100 Received: from diziet.irb.hr (localhost [127.0.0.1]) by diziet.irb.hr (8.13.5/8.13.5/Debian-3) with ESMTP id k2870QmB021966 for ; Wed, 8 Mar 2006 08:00:26 +0100 Received: (from mvela@localhost) by diziet.irb.hr (8.13.5/8.13.5/Submit) id k2870QvR021964; Wed, 8 Mar 2006 08:00:26 +0100 From: Matej Vela To: control@bugs.debian.org Subject: tag 24429 patch Date: Wed, 08 Mar 2006 08:00:26 +0100 Message-ID: <87slpte7zp.fsf@diziet.irb.hr> User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.51 on 161.53.22.8 Delivered-To: control@bugs.debian.org X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-5.0 required=4.0 tests=BAYES_00,VALID_BTS_CONTROL autolearn=no version=2.60-bugs.debian.org_2005_01_02 retitle 24429 ftplib prints perror msgs, and should check ftplib_debug first tag 24429 patch   Tags added: patch Request was from Matej Vela <vela@debian.org> to control@bugs.debian.org.   Received: (at control) by bugs.debian.org; 8 Mar 2006 07:00:03 +0000 From mvela@irb.hr Tue Mar 07 23:00:03 2006 Return-path: Received: from mail.irb.hr ([161.53.22.8] ident=UNKNOWN) by spohr.debian.org with esmtp (Exim 4.50) id 1FGseR-0006GV-Ap for control@bugs.debian.org; Tue, 07 Mar 2006 23:00:03 -0800 Received: from diziet.irb.hr (diziet.irb.hr [161.53.22.31]) by mail.irb.hr (8.13.4/8.13.4/Debian-3) with ESMTP id k286xjtZ006746 for ; Wed, 8 Mar 2006 07:59:45 +0100 Received: from diziet.irb.hr (localhost [127.0.0.1]) by diziet.irb.hr (8.13.5/8.13.5/Debian-3) with ESMTP id k2870QmB021966 for ; Wed, 8 Mar 2006 08:00:26 +0100 Received: (from mvela@localhost) by diziet.irb.hr (8.13.5/8.13.5/Submit) id k2870QvR021964; Wed, 8 Mar 2006 08:00:26 +0100 From: Matej Vela To: control@bugs.debian.org Subject: tag 24429 patch Date: Wed, 08 Mar 2006 08:00:26 +0100 Message-ID: <87slpte7zp.fsf@diziet.irb.hr> User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.51 on 161.53.22.8 Delivered-To: control@bugs.debian.org X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-5.0 required=4.0 tests=BAYES_00,VALID_BTS_CONTROL autolearn=no version=2.60-bugs.debian.org_2005_01_02 retitle 24429 ftplib prints perror msgs, and should check ftplib_debug first tag 24429 patch