Report forwarded to debian-bugs-dist@lists.debian.org, Steve Greenland <stevegr@debian.org>:
Bug#77313; Package cron.
debian-bugs-dist@lists.debian.orgSteve Greenland
Subject: Bug#77313: cron: misc source cleanups
Reply-To: Normal User , 77313@bugs.debian.org
Resent-From: Normal User
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Steve Greenland
Resent-Date: Fri, 17 Nov 2000 21:48:03 GMT
Resent-Message-ID:
Resent-Sender: owner@bugs.debian.org
X-Debian-PR-Message: report 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords:
X-Loop: owner@bugs.debian.org
Received: via spool by bugs@bugs.debian.org id=B.97449736728261
(code B ref -1); Fri, 17 Nov 2000 21:48:03 GMT
From: Normal User
To: submit@bugs.debian.org
X-Mailer: bug 3.3.7
Message-Id:
Date: Fri, 17 Nov 2000 15:42:42 -0600
Delivered-To: submit@bugs.debian.org
Package: cron
Version: 3.0pl1-60
Severity: wishlist
I'm doing a bit of hacking on cron to meet some local specifications and the
first part of this consisted in cleaning up the code a bit. I'm submitting
just the cleanup parts here in case you or anyone else wants them.
This patch removes all uses of the `register' and `auto' keywords, adds a
bunch of `const's, and converts function prototypes to ANSI-style (similar
to what the protoize command does).
diff -ur cron-3.0pl1.orig/bitstring.h cron-3.0pl1/bitstring.h
--- cron-3.0pl1.orig/bitstring.h Thu Sep 1 15:16:51 1994
+++ cron-3.0pl1/bitstring.h Thu Nov 16 18:21:09 2000
@@ -59,10 +59,10 @@
/* clear bits start ... stop in bitstring */
#define bit_nclear(name, start, stop) { \
- register bitstr_t *_name = name; \
- register int _start = start, _stop = stop; \
- register int _startbyte = _bit_byte(_start); \
- register int _stopbyte = _bit_byte(_stop); \
+ bitstr_t *_name = name; \
+ int _start = start, _stop = stop; \
+ int _startbyte = _bit_byte(_start); \
+ int _stopbyte = _bit_byte(_stop); \
if (_startbyte == _stopbyte) { \
_name[_startbyte] &= ((0xff >> (8 - (_start&0x7))) | \
(0xff << ((_stop&0x7) + 1))); \
@@ -76,10 +76,10 @@
/* set bits start ... stop in bitstring */
#define bit_nset(name, start, stop) { \
- register bitstr_t *_name = name; \
- register int _start = start, _stop = stop; \
- register int _startbyte = _bit_byte(_start); \
- register int _stopbyte = _bit_byte(_stop); \
+ bitstr_t *_name = name; \
+ int _start = start, _stop = stop; \
+ int _startbyte = _bit_byte(_start); \
+ int _stopbyte = _bit_byte(_stop); \
if (_startbyte == _stopbyte) { \
_name[_startbyte] |= ((0xff << (_start&0x7)) & \
(0xff >> (7 - (_stop&0x7)))); \
@@ -93,9 +93,9 @@
/* find first bit clear in name */
#define bit_ffc(name, nbits, value) { \
- register bitstr_t *_name = name; \
- register int _byte, _nbits = nbits; \
- register int _stopbyte = _bit_byte(_nbits), _value = -1; \
+ bitstr_t *_name = name; \
+ int _byte, _nbits = nbits; \
+ int _stopbyte = _bit_byte(_nbits), _value = -1; \
for (_byte = 0; _byte <= _stopbyte; ++_byte) \
if (_name[_byte] != 0xff) { \
_value = _byte << 3; \
@@ -108,9 +108,9 @@
/* find first bit set in name */
#define bit_ffs(name, nbits, value) { \
- register bitstr_t *_name = name; \
- register int _byte, _nbits = nbits; \
- register int _stopbyte = _bit_byte(_nbits), _value = -1; \
+ bitstr_t *_name = name; \
+ int _byte, _nbits = nbits; \
+ int _stopbyte = _bit_byte(_nbits), _value = -1; \
for (_byte = 0; _byte <= _stopbyte; ++_byte) \
if (_name[_byte]) { \
_value = _byte << 3; \
diff -ur cron-3.0pl1.orig/cron.c cron-3.0pl1/cron.c
--- cron-3.0pl1.orig/cron.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/cron.c Thu Nov 16 18:37:20 2000
@@ -45,7 +45,7 @@
static void
-usage() {
+usage(void) {
#if DEBUGGING
char **dflags;
@@ -61,9 +61,7 @@
int
-main(argc, argv)
- int argc;
- char *argv[];
+main(int argc, char **argv)
{
cron_db database;
@@ -246,11 +244,10 @@
static void
-run_reboot_jobs(db)
- cron_db *db;
+run_reboot_jobs(cron_db *db)
{
- register user *u;
- register entry *e;
+ user *u;
+ entry *e;
for (u = db->head; u != NULL; u = u->next) {
for (e = u->crontab; e != NULL; e = e->next) {
@@ -264,17 +261,13 @@
static void
-find_jobs(vtime, db, doWild, doNonWild)
- time_min vtime;
- cron_db *db;
- int doWild;
- int doNonWild;
+find_jobs(time_min vtime, cron_db *db, int doWild, int doNonWild)
{
time_t virtualSecond = vtime * SECONDS_PER_MINUTE;
- register struct tm *tm = localtime(&virtualSecond);
- register int minute, hour, dom, month, dow;
- register user *u;
- register entry *e;
+ struct tm *tm = localtime(&virtualSecond);
+ int minute, hour, dom, month, dow;
+ user *u;
+ entry *e;
/* make 0-based values out of these so we can use them as indicies
*/
@@ -320,7 +313,7 @@
* note that clockTime is a unix wallclock time converted to minutes
*/
static void
-set_time()
+set_time(void)
{
StartTime = time((time_t *)0);
clockTime = StartTime / (unsigned long)SECONDS_PER_MINUTE;
@@ -330,10 +323,9 @@
* try to just hit the next minute
*/
static void
-cron_sleep(target)
- time_min target;
+cron_sleep(time_min target)
{
- register int seconds_to_wait;
+ int seconds_to_wait;
seconds_to_wait = (int)(target*SECONDS_PER_MINUTE - time((time_t*)0)) + 1;
Debug(DSCH, ("[%d] TargetTime=%ld, sec-to-wait=%d\n",
@@ -380,7 +372,7 @@
static void
-sighup_handler(x) {
+sighup_handler(int x) {
log_close();
/* we should use sigaction for proper signal blocking as this
@@ -390,9 +382,7 @@
static void
-parse_args(argc, argv)
- int argc;
- char *argv[];
+parse_args(int argc, char **argv)
{
int argch;
diff -ur cron-3.0pl1.orig/cron.h cron-3.0pl1/cron.h
--- cron-3.0pl1.orig/cron.h Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/cron.h Thu Nov 16 20:01:14 2000
@@ -85,7 +85,6 @@
#define DBIT 0x0080 /* bit twiddling shown (long) */
#define CRON_TAB(u) "%s/%s", SPOOL_DIR, u
-#define REG register
#define PPC_NULL ((char **)NULL)
#ifndef MAXHOSTNAMELEN
@@ -188,46 +187,46 @@
} cron_db;
-void set_cron_uid __P((void)),
- set_cron_cwd __P((void)),
- load_database __P((cron_db *)),
- open_logfile __P((void)),
- sigpipe_func __P((void)),
- job_add __P((entry *, user *)),
- do_command __P((entry *, user *)),
- link_user __P((cron_db *, user *)),
- unlink_user __P((cron_db *, user *)),
- free_user __P((user *)),
- env_free __P((char **)),
- unget_char __P((int, FILE *)),
- free_entry __P((entry *)),
- acquire_daemonlock __P((int)),
- skip_comments __P((FILE *)),
- log_it __P((char *, int, char *, char *)),
- log_close __P((void));
-
-int job_runqueue __P((void)),
- set_debug_flags __P((char *)),
- get_char __P((FILE *)),
- get_string __P((char *, int, FILE *, char *)),
- swap_uids __P((void)),
- swap_uids_back __P((void)),
- load_env __P((char *, FILE *)),
- cron_pclose __P((FILE *)),
- strcmp_until __P((char *, char *, int)),
- allowed __P((char *)),
- strdtb __P((char *));
-
-char *env_get __P((char *, char **)),
- *arpadate __P((time_t *)),
- *mkprints __P((unsigned char *, unsigned int)),
- *first_word __P((char *, char *)),
- **env_init __P((void)),
- **env_copy __P((char **)),
- **env_set __P((char **, char *));
+void set_cron_uid __P((void));
+void set_cron_cwd __P((void));
+void load_database __P((cron_db *));
+void open_logfile __P((void));
+void sigpipe_func __P((void));
+void job_add __P((entry *, user *));
+void do_command __P((entry *, user *));
+void link_user __P((cron_db *, user *));
+void unlink_user __P((cron_db *, user *));
+void free_user __P((user *));
+void env_free __P((char **));
+void unget_char __P((int, FILE *));
+void free_entry __P((entry *));
+void acquire_daemonlock __P((int));
+void skip_comments __P((FILE *));
+void log_it __P((const char *, int, const char *, const char *));
+void log_close __P((void));
+
+int job_runqueue __P((void));
+int set_debug_flags __P((char *));
+int get_char __P((FILE *));
+int get_string __P((char *, int, FILE *, const char *));
+int swap_uids __P((void));
+int swap_uids_back __P((void));
+int load_env __P((char *, FILE *));
+int cron_pclose __P((FILE *));
+int strcmp_until __P((const char *, const char *, int));
+int allowed __P((const char *));
+int strdtb __P((char *));
+
+char *env_get __P((const char *, char **));
+char *arpadate __P((time_t *));
+char *mkprints __P((const unsigned char *, unsigned int));
+char *first_word __P((const char *, const char *));
+char **env_init __P((void));
+char **env_copy __P((char **));
+char **env_set __P((char **, char *));
-user *load_user __P((int, struct passwd *, char *)),
- *find_user __P((cron_db *, char *));
+user *load_user __P((int, struct passwd *, const char *));
+user *find_user __P((cron_db *, const char *));
entry *load_entry __P((FILE *, void (*)(),
struct passwd *, char **));
@@ -242,19 +241,19 @@
#ifdef MAIN_PROGRAM
# if !defined(LINT) && !defined(lint)
-char *copyright[] = {
+const char *copyright[] = {
"@(#) Copyright 1988,1989,1990,1993,1994 by Paul Vixie",
"@(#) All rights reserved"
};
# endif
-char *MonthNames[] = {
+const char *MonthNames[] = {
"Jan", "Feb", "Mar", "Apr", "May", "Jun",
"Jul", "Aug", "Sep", "Oct", "Nov", "Dec",
NULL
};
-char *DowNames[] = {
+const char *DowNames[] = {
"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun",
NULL
};
@@ -268,16 +267,16 @@
# if DEBUGGING
int DebugFlags;
-char *DebugFlagNames[] = { /* sync with #defines */
+const char *DebugFlagNames[] = { /* sync with #defines */
"ext", "sch", "proc", "pars", "load", "misc", "test", "bit",
NULL /* NULL must be last element */
};
# endif /* DEBUGGING */
#else /*MAIN_PROGRAM*/
-extern char *copyright[],
- *MonthNames[],
- *DowNames[],
- *ProgramName;
+extern char *copyright[];
+extern char *MonthNames[];
+extern char *DowNames[];
+extern char *ProgramName;
extern int LineNumber;
extern time_t StartTime;
extern time_min timeRunning;
diff -ur cron-3.0pl1.orig/crontab.c cron-3.0pl1/crontab.c
--- cron-3.0pl1.orig/crontab.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/crontab.c Thu Nov 16 19:28:49 2000
@@ -51,7 +51,7 @@
enum opt_t { opt_unknown, opt_list, opt_delete, opt_edit, opt_replace };
#if DEBUGGING
-static char *Options[] = { "???", "list", "delete", "edit", "replace" };
+static const char *Options[] = { "???", "list", "delete", "edit", "replace" };
#endif
@@ -66,14 +66,13 @@
delete_cmd __P((void)),
edit_cmd __P((void)),
poke_daemon __P((void)),
- check_error __P((char *)),
+ check_error __P((const char *)),
parse_args __P((int c, char *v[]));
static int replace_cmd __P((void));
static void
-usage(msg)
- char *msg;
+usage(const char *msg)
{
fprintf(stderr, "%s: usage error: %s\n", ProgramName, msg);
fprintf(stderr, "usage:\t%s [-u user] file\n", ProgramName);
@@ -87,9 +86,7 @@
int
-main(argc, argv)
- int argc;
- char *argv[];
+main(int argc, char **argv)
{
int exitstatus;
@@ -137,16 +134,14 @@
}
#if DEBUGGING
-char *getoptarg = "u:lerx:";
+const char *getoptarg = "u:lerx:";
#else
-char *getoptarg = "u:ler";
+const char *getoptarg = "u:ler";
#endif
static void
-parse_args(argc, argv)
- int argc;
- char *argv[];
+parse_args(int argc, char **argv)
{
int argch;
@@ -262,7 +257,7 @@
static void
-list_cmd() {
+list_cmd(void) {
char n[MAX_FNAME];
FILE *f;
int ch;
@@ -315,7 +310,7 @@
static void
-delete_cmd() {
+delete_cmd(void) {
char n[MAX_FNAME];
log_it(RealUser, Pid, "DELETE", User);
@@ -332,8 +327,7 @@
static void
-check_error(msg)
- char *msg;
+check_error(const char *msg)
{
CheckErrorCount++;
fprintf(stderr, "\"%s\":%d: %s\n", Filename, LineNumber-1, msg);
@@ -341,8 +335,9 @@
static void
-edit_cmd() {
- char n[MAX_FNAME], q[MAX_TEMPSTR], *editor;
+edit_cmd(void) {
+ char n[MAX_FNAME], q[MAX_TEMPSTR];
+ const char *editor;
FILE *f;
int ch, t, x;
struct stat statbuf;
@@ -569,7 +564,7 @@
* -2 on install error
*/
static int
-replace_cmd() {
+replace_cmd(void) {
char n[MAX_FNAME], envstr[MAX_ENVSTR], tn[MAX_FNAME];
FILE *tmp;
int ch, eof;
@@ -688,7 +683,7 @@
static void
-poke_daemon() {
+poke_daemon(void) {
#ifdef USE_UTIMES
struct timeval tvs[2];
struct timezone tz;
diff -ur cron-3.0pl1.orig/database.c cron-3.0pl1/database.c
--- cron-3.0pl1.orig/database.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/database.c Thu Nov 16 19:46:19 2000
@@ -44,16 +44,16 @@
#endif /* ifndef PATH_MAX */
-static void process_crontab __P((char *, char *, char *,
+static void process_crontab __P((const char *, const char *,
+ const char *,
struct stat *,
cron_db *, cron_db *));
#ifdef DEBIAN
-static int valid_name (char *filename);
+static int valid_name (const char *filename);
static user *get_next_system_crontab __P((user *));
#endif
void
-load_database(old_db)
- cron_db *old_db;
+load_database(cron_db *old_db)
{
DIR *dir;
struct stat statbuf;
@@ -257,9 +257,7 @@
void
-link_user(db, u)
- cron_db *db;
- user *u;
+link_user(cron_db *db, user *u)
{
if (db->head == NULL)
db->head = u;
@@ -272,9 +270,7 @@
void
-unlink_user(db, u)
- cron_db *db;
- user *u;
+unlink_user(cron_db *db, user *u)
{
if (u->prev == NULL)
db->head = u->next;
@@ -289,11 +285,9 @@
user *
-find_user(db, name)
- cron_db *db;
- char *name;
+find_user(cron_db *db, const char *name)
{
- char *env_get();
+ char *env_get(const char *name, char **envp);
user *u;
for (u = db->head; u != NULL; u = u->next)
@@ -304,13 +298,7 @@
static void
-process_crontab(uname, fname, tabname, statbuf, new_db, old_db)
- char *uname;
- char *fname;
- char *tabname;
- struct stat *statbuf;
- cron_db *new_db;
- cron_db *old_db;
+process_crontab(const char *uname, const char *fname, const char *tabname, struct stat *statbuf, cron_db *new_db, cron_db *old_db)
{
struct passwd *pw = NULL;
int crontab_fd = OK - 1;
@@ -405,7 +393,7 @@
#else
#include
/* Same function, better compliance with ISO C */
-static int valid_name (char *filename)
+static int valid_name (const char *filename)
{
while (*filename) {
if (!(isalnum(*filename) ||
@@ -420,8 +408,7 @@
#endif
static user *
-get_next_system_crontab (curtab)
- user *curtab;
+get_next_system_crontab (user *curtab)
{
for ( ; curtab != NULL; curtab = curtab->next)
if (!strncmp(curtab->name, "*system*", 8) && curtab->name [8])
diff -ur cron-3.0pl1.orig/debian/rules cron-3.0pl1/debian/rules
--- cron-3.0pl1.orig/debian/rules Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/debian/rules Thu Nov 16 18:41:36 2000
@@ -6,7 +6,7 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
-DEB_OPTIM= -O2 -Wall
+DEB_OPTIM= -O2 -Wall -pedantic
DEB_INSTALL = install
DEB_DEBUG_DEFS = -DDEBUGGING=0
diff -ur cron-3.0pl1.orig/do_command.c cron-3.0pl1/do_command.c
--- cron-3.0pl1.orig/do_command.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/do_command.c Thu Nov 16 19:21:56 2000
@@ -48,9 +48,7 @@
void
-do_command(e, u)
- entry *e;
- user *u;
+do_command(entry *e, user *u)
{
Debug(DPROC, ("[%d] do_command(%s, (%s,%d,%d))\n",
getpid(), e->cmd, u->name, e->uid, e->gid))
@@ -82,12 +80,10 @@
static void
-child_process(e, u)
- entry *e;
- user *u;
+child_process(entry *e, user *u)
{
int stdin_pipe[2], stdout_pipe[2];
- register char *input_data;
+ char *input_data;
char *usernm, *mailto;
int children = 0;
@@ -101,7 +97,7 @@
* our program name. This has no effect on some kernels.
*/
/*local*/{
- register char *pch;
+ char *pch;
for (pch = ProgramName; *pch; pch++)
*pch = MkUpper(*pch);
@@ -162,9 +158,9 @@
* If there are escaped %'s, remove the escape character.
*/
/*local*/{
- register int escaped = FALSE;
- register int ch;
- register char *p;
+ int escaped = FALSE;
+ int ch;
+ char *p;
for (input_data = p = e->cmd; (ch = *input_data);
input_data++, p++) {
@@ -337,10 +333,10 @@
*/
if (*input_data && fork() == 0) {
- register FILE *out = fdopen(stdin_pipe[WRITE_PIPE], "w");
- register int need_newline = FALSE;
- register int escaped = FALSE;
- register int ch;
+ FILE *out = fdopen(stdin_pipe[WRITE_PIPE], "w");
+ int need_newline = FALSE;
+ int escaped = FALSE;
+ int ch;
Debug(DPROC, ("[%d] child2 sending data to grandchild\n", getpid()))
@@ -399,12 +395,12 @@
Debug(DPROC, ("[%d] child reading output from grandchild\n", getpid()))
/*local*/{
- register FILE *in = fdopen(stdout_pipe[READ_PIPE], "r");
- register int ch = getc(in);
+ FILE *in = fdopen(stdout_pipe[READ_PIPE], "r");
+ int ch = getc(in);
if (ch != EOF) {
- register FILE *mail;
- register int bytes = 1;
+ FILE *mail;
+ int bytes = 1;
int status = 0;
Debug(DPROC|DEXT,
@@ -434,9 +430,9 @@
*/
if (mailto) {
- register char **env;
- auto char mailcmd[MAX_COMMAND];
- auto char hostname[MAXHOSTNAMELEN];
+ char **env;
+ char mailcmd[MAX_COMMAND];
+ char hostname[MAXHOSTNAMELEN];
(void) gethostname(hostname, MAXHOSTNAMELEN);
(void) snprintf(mailcmd, sizeof(mailcmd),
@@ -542,8 +538,7 @@
static void
-do_univ(u)
- user *u;
+do_univ(user *u)
{
#if defined(sequent)
/* Dynix (Sequent) hack to put the user associated with
diff -ur cron-3.0pl1.orig/entry.c cron-3.0pl1/entry.c
--- cron-3.0pl1.orig/entry.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/entry.c Fri Nov 17 15:24:57 2000
@@ -39,7 +39,7 @@
get_number __P((int *, int, char *[], int, FILE *));
static int set_element __P((bitstr_t *, int, int, int));
-static char *ecodes[] =
+static const char *ecodes[] =
{
"no error",
"bad minute",
@@ -54,8 +54,7 @@
void
-free_entry(e)
- entry *e;
+free_entry(entry *e)
{
free(e->cmd);
env_free(e->envp);
@@ -67,11 +66,7 @@
* otherwise return a pointer to a new entry.
*/
entry *
-load_entry(file, error_func, pw, envp)
- FILE *file;
- void (*error_func)();
- struct passwd *pw;
- char **envp;
+load_entry(FILE *file, void (*error_func) (/* ??? */), struct passwd *pw, char **envp)
{
/* this function reads one crontab entry -- the next -- from a file.
* it skips any leading blank lines, ignores comments, and returns
@@ -348,15 +343,15 @@
}
+/* bits: one bit per flag, default=FALSE */
+/* low, high: bounds, impl. offset for bitstr */
+/* names: NULL or *[] of names for these elements */
+/* ch: current character being processed */
+/* file: file being read */
static char
-get_list(bits, low, high, names, ch, file)
- bitstr_t *bits; /* one bit per flag, default=FALSE */
- int low, high; /* bounds, impl. offset for bitstr */
- char *names[]; /* NULL or *[] of names for these elements */
- int ch; /* current character being processed */
- FILE *file; /* file being read */
+get_list(bitstr_t *bits, int low, int high, char **names, int ch, FILE *file)
{
- register int done;
+ int done;
/* we know that we point to a non-blank character here;
* must do a Skip_Blanks before we exit, so that the
@@ -395,19 +390,19 @@
}
+/* bits: one bit per flag, default=FALSE */
+/* low, high: bounds, impl. offset for bitstr */
+/* names: NULL or names of elements */
+/* ch: current character being processed */
+/* file: file being read */
static char
-get_range(bits, low, high, names, ch, file)
- bitstr_t *bits; /* one bit per flag, default=FALSE */
- int low, high; /* bounds, impl. offset for bitstr */
- char *names[]; /* NULL or names of elements */
- int ch; /* current character being processed */
- FILE *file; /* file being read */
+get_range(bitstr_t *bits, int low, int high, char **names, int ch, FILE *file)
{
/* range = number | number "-" number [ "/" number ]
*/
- register int i;
- auto int num1, num2, num3;
+ int i;
+ int num1, num2, num3;
Debug(DPARS|DEXT, ("get_range()...entering, exit won't show\n"))
@@ -480,13 +475,13 @@
}
+/* numptr: where does the result go? */
+/* low: offset applied to result if symbolic enum used */
+/* names: symbolic names, if any, for enums */
+/* ch: current character */
+/* FILE: source */
static char
-get_number(numptr, low, names, ch, file)
- int *numptr; /* where does the result go? */
- int low; /* offset applied to result if symbolic enum used */
- char *names[]; /* symbolic names, if any, for enums */
- int ch; /* current character */
- FILE *file; /* source */
+get_number(int *numptr, int low, char **names, int ch, FILE *file)
{
char temp[MAX_TEMPSTR], *pc;
int len, i, all_digits;
@@ -535,12 +530,9 @@
}
+/* bits: one bit per flag, default=FALSE */
static int
-set_element(bits, low, high, number)
- bitstr_t *bits; /* one bit per flag, default=FALSE */
- int low;
- int high;
- int number;
+set_element(bitstr_t *bits, int low, int high, int number)
{
Debug(DPARS|DEXT, ("set_element(?,%d,%d,%d)\n", low, high, number))
diff -ur cron-3.0pl1.orig/env.c cron-3.0pl1/env.c
--- cron-3.0pl1.orig/env.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/env.c Thu Nov 16 19:33:20 2000
@@ -24,9 +24,9 @@
char **
-env_init()
+env_init(void)
{
- register char **p = (char **) malloc(sizeof(char **));
+ char **p = (char **) malloc(sizeof(char **));
if (p)
p[0] = NULL;
@@ -35,8 +35,7 @@
void
-env_free(envp)
- char **envp;
+env_free(char **envp)
{
char **p;
@@ -47,11 +46,10 @@
char **
-env_copy(envp)
- register char **envp;
+env_copy(char **envp)
{
- register int count, i;
- register char **p;
+ int count, i;
+ char **p;
for (count = 0; envp[count] != NULL; count++)
;
@@ -74,12 +72,10 @@
char **
-env_set(envp, envstr)
- char **envp;
- char *envstr;
+env_set(char **envp, char *envstr)
{
- register int count, found;
- register char **p;
+ int count, found;
+ char **p;
/*
* count the number of elements, including the null pointer;
@@ -131,9 +127,7 @@
* TRUE = was an env setting
*/
int
-load_env(envstr, f)
- char *envstr;
- FILE *f;
+load_env(char *envstr, FILE *f)
{
long filepos;
int fileline;
@@ -187,12 +181,10 @@
char *
-env_get(name, envp)
- register char *name;
- register char **envp;
+env_get(const char *name, char **envp)
{
- register int len = strlen(name);
- register char *p, *q;
+ int len = strlen(name);
+ char *p, *q;
while ((p = *envp++)) {
if (!(q = strchr(p, '=')))
diff -ur cron-3.0pl1.orig/job.c cron-3.0pl1/job.c
--- cron-3.0pl1.orig/job.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/job.c Thu Nov 16 18:37:20 2000
@@ -34,11 +34,9 @@
void
-job_add(e, u)
- register entry *e;
- register user *u;
+job_add(entry *e, user *u)
{
- register job *j;
+ job *j;
/* if already on queue, keep going */
for (j=jhead; j; j=j->next)
@@ -59,10 +57,10 @@
int
-job_runqueue()
+job_runqueue(void)
{
- register job *j, *jn;
- register int run = 0;
+ job *j, *jn;
+ int run = 0;
for (j=jhead; j; j=jn) {
do_command(j->e, j->u);
diff -ur cron-3.0pl1.orig/misc.c cron-3.0pl1/misc.c
--- cron-3.0pl1.orig/misc.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/misc.c Thu Nov 16 19:54:43 2000
@@ -49,12 +49,9 @@
int
-strcmp_until(left, right, until)
- char *left;
- char *right;
- int until;
+strcmp_until(const char *left, const char *right, int until)
{
- register int diff;
+ int diff;
while (*left && *left != until && *left == *right) {
left++;
@@ -75,8 +72,7 @@
/* strdtb(s) - delete trailing blanks in string 's' and return new length
*/
int
-strdtb(s)
- char *s;
+strdtb(char *s)
{
char *x = s;
@@ -104,8 +100,7 @@
int
-set_debug_flags(flags)
- char *flags;
+set_debug_flags(char *flags)
{
/* debug flags are of the form flag[,flag ...]
*
@@ -171,7 +166,7 @@
void
-set_cron_uid()
+set_cron_uid(void)
{
#if defined(BSD) || defined(POSIX)
if (seteuid(ROOT_UID) < OK) {
@@ -188,7 +183,7 @@
void
-set_cron_cwd()
+set_cron_cwd(void)
{
struct stat sb;
@@ -247,8 +242,7 @@
* it would be great if fflush() disassociated the file buffer.
*/
void
-acquire_daemonlock(closeflag)
- int closeflag;
+acquire_daemonlock(int closeflag)
{
static FILE *fp = NULL;
@@ -303,8 +297,7 @@
/* get_char(file) : like getc() but increment LineNumber on newlines
*/
int
-get_char(file)
- FILE *file;
+get_char(FILE *file)
{
int ch;
@@ -318,9 +311,7 @@
/* unget_char(ch, file) : like ungetc but do LineNumber processing
*/
void
-unget_char(ch, file)
- int ch;
- FILE *file;
+unget_char(int ch, FILE *file)
{
ungetc(ch, file);
if (ch == '\n')
@@ -335,11 +326,7 @@
* (4) returns EOF or terminating character, whichever
*/
int
-get_string(string, size, file, terms)
- char *string;
- int size;
- FILE *file;
- char *terms;
+get_string(char *string, int size, FILE *file, const char *terms)
{
int ch;
@@ -360,8 +347,7 @@
/* skip_comments(file) : read past comment (if any)
*/
void
-skip_comments(file)
- FILE *file;
+skip_comments(FILE *file)
{
int ch;
@@ -397,14 +383,12 @@
}
-/* int in_file(char *string, FILE *file)
+/* int in_file(const char *string, FILE *file)
* return TRUE if one of the lines in file matches string exactly,
* FALSE otherwise.
*/
static int
-in_file(string, file)
- char *string;
- FILE *file;
+in_file(const char *string, FILE *file)
{
char line[MAX_TEMPSTR];
@@ -425,8 +409,7 @@
* or (neither file exists but user=="root" so it's okay)
*/
int
-allowed(username)
- char *username;
+allowed(const char *username)
{
static int init = FALSE;
static FILE *allow, *deny;
@@ -475,17 +458,13 @@
#endif /* SYSLOG */
void
-log_it(username, xpid, event, detail)
- char *username;
- int xpid;
- char *event;
- char *detail;
+log_it(const char *username, int xpid, const char *event, const char *detail)
{
#if defined(LOG_FILE)
PID_T pid = xpid;
char *msg;
TIME_T now = time((TIME_T) 0);
- register struct tm *t = localtime(&now);
+ struct tm *t = localtime(&now);
int msg_size;
#endif /*LOG_FILE*/
@@ -602,7 +581,7 @@
void
-log_close() {
+log_close(void) {
#if defined(LOG_FILE)
if (LogFD != ERR) {
close(LogFD);
@@ -620,14 +599,14 @@
* (1) this routine is fairly slow
* (2) it returns a pointer to static storage
*/
+/* s: string we want the first word of */
+/* t: terminators, implicitly including \0 */
char *
-first_word(s, t)
- register char *s; /* string we want the first word of */
- register char *t; /* terminators, implicitly including \0 */
+first_word(const char *s, const char *t)
{
static char retbuf[2][MAX_TEMPSTR + 1]; /* sure wish C had GC */
static int retsel = 0;
- register char *rb, *rp;
+ char *rb, *rp;
/* select a return buffer */
retsel = 1-retsel;
@@ -654,14 +633,11 @@
* heavily ascii-dependent.
*/
void
-mkprint(dst, src, len)
- register char *dst;
- register unsigned char *src;
- register int len;
+mkprint(char *dst, const unsigned char *src, int len)
{
while (len-- > 0)
{
- register unsigned char ch = *src++;
+ unsigned char ch = *src++;
if (ch < ' ') { /* control character */
*dst++ = '^';
@@ -686,11 +662,9 @@
* returns a pointer to malloc'd storage, you must call free yourself.
*/
char *
-mkprints(src, len)
- register unsigned char *src;
- register unsigned int len;
+mkprints(const unsigned char *src, unsigned int len)
{
- register char *dst = malloc(len*4 + 1);
+ char *dst = malloc(len*4 + 1);
if (dst)
mkprint(dst, src, len);
@@ -704,8 +678,7 @@
* 1234567890123456789012345678901234567
*/
char *
-arpadate(clock)
- time_t *clock;
+arpadate(time_t *clock)
{
static char ret[64]; /* zone name might be >3 chars */
time_t t = clock ? *clock : time(NULL);
@@ -740,6 +713,6 @@
int swap_uids() { save_euid = geteuid(); return seteuid(getuid()); }
int swap_uids_back() { return seteuid(save_euid); }
#else /*HAVE_SAVED_UIDS*/
-int swap_uids() { return setreuid(geteuid(), getuid()); }
-int swap_uids_back() { return swap_uids(); }
+int swap_uids(void) { return setreuid(geteuid(), getuid()); }
+int swap_uids_back(void) { return swap_uids(); }
#endif /*HAVE_SAVED_UIDS*/
diff -ur cron-3.0pl1.orig/popen.c cron-3.0pl1/popen.c
--- cron-3.0pl1.orig/popen.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/popen.c Thu Nov 16 18:37:21 2000
@@ -48,11 +48,9 @@
static int fds;
FILE *
-cron_popen(program, type, e)
- char *program, *type;
- entry *e;
+cron_popen(char *program, char *type, entry *e)
{
- register char *cp;
+ char *cp;
FILE *iop;
int argc, pdes[2];
PID_T pid;
@@ -156,10 +154,9 @@
}
int
-cron_pclose(iop)
- FILE *iop;
+cron_pclose(FILE *iop)
{
- register int fdes;
+ int fdes;
int omask;
WAIT_T stat_loc;
PID_T pid;
diff -ur cron-3.0pl1.orig/user.c cron-3.0pl1/user.c
--- cron-3.0pl1.orig/user.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/user.c Thu Nov 16 19:29:41 2000
@@ -27,8 +27,7 @@
void
-free_user(u)
- user *u;
+free_user(user *u)
{
entry *e, *ne;
@@ -42,10 +41,10 @@
user *
-load_user(crontab_fd, pw, name)
- int crontab_fd;
- struct passwd *pw; /* NULL implies syscrontab */
- char *name;
+load_user(int crontab_fd, struct passwd *pw, const char *name)
+
+ /* NULL implies syscrontab */
+
{
char envstr[MAX_ENVSTR];
FILE *file;
Acknowledgement sent to Normal User <gohmandj@mrs.umn.edu>:
New Bug report received and forwarded. Copy sent to Steve Greenland <stevegr@debian.org>.
-t
From: owner@bugs.debian.org (Debian Bug Tracking System)
To: Normal User
Subject: Bug#77313: Acknowledgement (cron: misc source cleanups)
Message-ID:
In-Reply-To:
References:
X-Debian-PR-Message: ack 77313
Thank you for the problem report you have sent regarding Debian.
This is an automatically generated reply, to let you know your message has
been received. It is being forwarded to the developers mailing list for
their attention; they will reply in due course.
Your message has been sent to the package maintainer(s):
Steve Greenland
If you wish to submit further information on your problem, please send
it to 77313@bugs.debian.org (and *not* to
bugs@bugs.debian.org).
Please do not reply to the address at the top of this message,
unless you wish to report a problem with the Bug-tracking system.
Darren Benham
(administrator, Debian Bugs database)
Received: (at submit) by bugs.debian.org; 17 Nov 2000 21:42:47 +0000
From gohmandj@mrs.umn.edu Fri Nov 17 15:42:47 2000
Return-path:
Received: from rn082040.mrs.umn.edu [146.57.82.40]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 13wtHT-0007Lg-00; Fri, 17 Nov 2000 15:42:47 -0600
Received: from normal by rn082040.mrs.umn.edu with local (Exim 3.16 #1 (Debian))
id 13wtHO-0002u6-00; Fri, 17 Nov 2000 15:42:42 -0600
From: Normal User
Subject: cron: misc source cleanups
To: submit@bugs.debian.org
X-Mailer: bug 3.3.7
Message-Id:
Date: Fri, 17 Nov 2000 15:42:42 -0600
Delivered-To: submit@bugs.debian.org
Package: cron
Version: 3.0pl1-60
Severity: wishlist
I'm doing a bit of hacking on cron to meet some local specifications and the
first part of this consisted in cleaning up the code a bit. I'm submitting
just the cleanup parts here in case you or anyone else wants them.
This patch removes all uses of the `register' and `auto' keywords, adds a
bunch of `const's, and converts function prototypes to ANSI-style (similar
to what the protoize command does).
diff -ur cron-3.0pl1.orig/bitstring.h cron-3.0pl1/bitstring.h
--- cron-3.0pl1.orig/bitstring.h Thu Sep 1 15:16:51 1994
+++ cron-3.0pl1/bitstring.h Thu Nov 16 18:21:09 2000
@@ -59,10 +59,10 @@
/* clear bits start ... stop in bitstring */
#define bit_nclear(name, start, stop) { \
- register bitstr_t *_name = name; \
- register int _start = start, _stop = stop; \
- register int _startbyte = _bit_byte(_start); \
- register int _stopbyte = _bit_byte(_stop); \
+ bitstr_t *_name = name; \
+ int _start = start, _stop = stop; \
+ int _startbyte = _bit_byte(_start); \
+ int _stopbyte = _bit_byte(_stop); \
if (_startbyte == _stopbyte) { \
_name[_startbyte] &= ((0xff >> (8 - (_start&0x7))) | \
(0xff << ((_stop&0x7) + 1))); \
@@ -76,10 +76,10 @@
/* set bits start ... stop in bitstring */
#define bit_nset(name, start, stop) { \
- register bitstr_t *_name = name; \
- register int _start = start, _stop = stop; \
- register int _startbyte = _bit_byte(_start); \
- register int _stopbyte = _bit_byte(_stop); \
+ bitstr_t *_name = name; \
+ int _start = start, _stop = stop; \
+ int _startbyte = _bit_byte(_start); \
+ int _stopbyte = _bit_byte(_stop); \
if (_startbyte == _stopbyte) { \
_name[_startbyte] |= ((0xff << (_start&0x7)) & \
(0xff >> (7 - (_stop&0x7)))); \
@@ -93,9 +93,9 @@
/* find first bit clear in name */
#define bit_ffc(name, nbits, value) { \
- register bitstr_t *_name = name; \
- register int _byte, _nbits = nbits; \
- register int _stopbyte = _bit_byte(_nbits), _value = -1; \
+ bitstr_t *_name = name; \
+ int _byte, _nbits = nbits; \
+ int _stopbyte = _bit_byte(_nbits), _value = -1; \
for (_byte = 0; _byte <= _stopbyte; ++_byte) \
if (_name[_byte] != 0xff) { \
_value = _byte << 3; \
@@ -108,9 +108,9 @@
/* find first bit set in name */
#define bit_ffs(name, nbits, value) { \
- register bitstr_t *_name = name; \
- register int _byte, _nbits = nbits; \
- register int _stopbyte = _bit_byte(_nbits), _value = -1; \
+ bitstr_t *_name = name; \
+ int _byte, _nbits = nbits; \
+ int _stopbyte = _bit_byte(_nbits), _value = -1; \
for (_byte = 0; _byte <= _stopbyte; ++_byte) \
if (_name[_byte]) { \
_value = _byte << 3; \
diff -ur cron-3.0pl1.orig/cron.c cron-3.0pl1/cron.c
--- cron-3.0pl1.orig/cron.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/cron.c Thu Nov 16 18:37:20 2000
@@ -45,7 +45,7 @@
static void
-usage() {
+usage(void) {
#if DEBUGGING
char **dflags;
@@ -61,9 +61,7 @@
int
-main(argc, argv)
- int argc;
- char *argv[];
+main(int argc, char **argv)
{
cron_db database;
@@ -246,11 +244,10 @@
static void
-run_reboot_jobs(db)
- cron_db *db;
+run_reboot_jobs(cron_db *db)
{
- register user *u;
- register entry *e;
+ user *u;
+ entry *e;
for (u = db->head; u != NULL; u = u->next) {
for (e = u->crontab; e != NULL; e = e->next) {
@@ -264,17 +261,13 @@
static void
-find_jobs(vtime, db, doWild, doNonWild)
- time_min vtime;
- cron_db *db;
- int doWild;
- int doNonWild;
+find_jobs(time_min vtime, cron_db *db, int doWild, int doNonWild)
{
time_t virtualSecond = vtime * SECONDS_PER_MINUTE;
- register struct tm *tm = localtime(&virtualSecond);
- register int minute, hour, dom, month, dow;
- register user *u;
- register entry *e;
+ struct tm *tm = localtime(&virtualSecond);
+ int minute, hour, dom, month, dow;
+ user *u;
+ entry *e;
/* make 0-based values out of these so we can use them as indicies
*/
@@ -320,7 +313,7 @@
* note that clockTime is a unix wallclock time converted to minutes
*/
static void
-set_time()
+set_time(void)
{
StartTime = time((time_t *)0);
clockTime = StartTime / (unsigned long)SECONDS_PER_MINUTE;
@@ -330,10 +323,9 @@
* try to just hit the next minute
*/
static void
-cron_sleep(target)
- time_min target;
+cron_sleep(time_min target)
{
- register int seconds_to_wait;
+ int seconds_to_wait;
seconds_to_wait = (int)(target*SECONDS_PER_MINUTE - time((time_t*)0)) + 1;
Debug(DSCH, ("[%d] TargetTime=%ld, sec-to-wait=%d\n",
@@ -380,7 +372,7 @@
static void
-sighup_handler(x) {
+sighup_handler(int x) {
log_close();
/* we should use sigaction for proper signal blocking as this
@@ -390,9 +382,7 @@
static void
-parse_args(argc, argv)
- int argc;
- char *argv[];
+parse_args(int argc, char **argv)
{
int argch;
diff -ur cron-3.0pl1.orig/cron.h cron-3.0pl1/cron.h
--- cron-3.0pl1.orig/cron.h Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/cron.h Thu Nov 16 20:01:14 2000
@@ -85,7 +85,6 @@
#define DBIT 0x0080 /* bit twiddling shown (long) */
#define CRON_TAB(u) "%s/%s", SPOOL_DIR, u
-#define REG register
#define PPC_NULL ((char **)NULL)
#ifndef MAXHOSTNAMELEN
@@ -188,46 +187,46 @@
} cron_db;
-void set_cron_uid __P((void)),
- set_cron_cwd __P((void)),
- load_database __P((cron_db *)),
- open_logfile __P((void)),
- sigpipe_func __P((void)),
- job_add __P((entry *, user *)),
- do_command __P((entry *, user *)),
- link_user __P((cron_db *, user *)),
- unlink_user __P((cron_db *, user *)),
- free_user __P((user *)),
- env_free __P((char **)),
- unget_char __P((int, FILE *)),
- free_entry __P((entry *)),
- acquire_daemonlock __P((int)),
- skip_comments __P((FILE *)),
- log_it __P((char *, int, char *, char *)),
- log_close __P((void));
-
-int job_runqueue __P((void)),
- set_debug_flags __P((char *)),
- get_char __P((FILE *)),
- get_string __P((char *, int, FILE *, char *)),
- swap_uids __P((void)),
- swap_uids_back __P((void)),
- load_env __P((char *, FILE *)),
- cron_pclose __P((FILE *)),
- strcmp_until __P((char *, char *, int)),
- allowed __P((char *)),
- strdtb __P((char *));
-
-char *env_get __P((char *, char **)),
- *arpadate __P((time_t *)),
- *mkprints __P((unsigned char *, unsigned int)),
- *first_word __P((char *, char *)),
- **env_init __P((void)),
- **env_copy __P((char **)),
- **env_set __P((char **, char *));
+void set_cron_uid __P((void));
+void set_cron_cwd __P((void));
+void load_database __P((cron_db *));
+void open_logfile __P((void));
+void sigpipe_func __P((void));
+void job_add __P((entry *, user *));
+void do_command __P((entry *, user *));
+void link_user __P((cron_db *, user *));
+void unlink_user __P((cron_db *, user *));
+void free_user __P((user *));
+void env_free __P((char **));
+void unget_char __P((int, FILE *));
+void free_entry __P((entry *));
+void acquire_daemonlock __P((int));
+void skip_comments __P((FILE *));
+void log_it __P((const char *, int, const char *, const char *));
+void log_close __P((void));
+
+int job_runqueue __P((void));
+int set_debug_flags __P((char *));
+int get_char __P((FILE *));
+int get_string __P((char *, int, FILE *, const char *));
+int swap_uids __P((void));
+int swap_uids_back __P((void));
+int load_env __P((char *, FILE *));
+int cron_pclose __P((FILE *));
+int strcmp_until __P((const char *, const char *, int));
+int allowed __P((const char *));
+int strdtb __P((char *));
+
+char *env_get __P((const char *, char **));
+char *arpadate __P((time_t *));
+char *mkprints __P((const unsigned char *, unsigned int));
+char *first_word __P((const char *, const char *));
+char **env_init __P((void));
+char **env_copy __P((char **));
+char **env_set __P((char **, char *));
-user *load_user __P((int, struct passwd *, char *)),
- *find_user __P((cron_db *, char *));
+user *load_user __P((int, struct passwd *, const char *));
+user *find_user __P((cron_db *, const char *));
entry *load_entry __P((FILE *, void (*)(),
struct passwd *, char **));
@@ -242,19 +241,19 @@
#ifdef MAIN_PROGRAM
# if !defined(LINT) && !defined(lint)
-char *copyright[] = {
+const char *copyright[] = {
"@(#) Copyright 1988,1989,1990,1993,1994 by Paul Vixie",
"@(#) All rights reserved"
};
# endif
-char *MonthNames[] = {
+const char *MonthNames[] = {
"Jan", "Feb", "Mar", "Apr", "May", "Jun",
"Jul", "Aug", "Sep", "Oct", "Nov", "Dec",
NULL
};
-char *DowNames[] = {
+const char *DowNames[] = {
"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun",
NULL
};
@@ -268,16 +267,16 @@
# if DEBUGGING
int DebugFlags;
-char *DebugFlagNames[] = { /* sync with #defines */
+const char *DebugFlagNames[] = { /* sync with #defines */
"ext", "sch", "proc", "pars", "load", "misc", "test", "bit",
NULL /* NULL must be last element */
};
# endif /* DEBUGGING */
#else /*MAIN_PROGRAM*/
-extern char *copyright[],
- *MonthNames[],
- *DowNames[],
- *ProgramName;
+extern char *copyright[];
+extern char *MonthNames[];
+extern char *DowNames[];
+extern char *ProgramName;
extern int LineNumber;
extern time_t StartTime;
extern time_min timeRunning;
diff -ur cron-3.0pl1.orig/crontab.c cron-3.0pl1/crontab.c
--- cron-3.0pl1.orig/crontab.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/crontab.c Thu Nov 16 19:28:49 2000
@@ -51,7 +51,7 @@
enum opt_t { opt_unknown, opt_list, opt_delete, opt_edit, opt_replace };
#if DEBUGGING
-static char *Options[] = { "???", "list", "delete", "edit", "replace" };
+static const char *Options[] = { "???", "list", "delete", "edit", "replace" };
#endif
@@ -66,14 +66,13 @@
delete_cmd __P((void)),
edit_cmd __P((void)),
poke_daemon __P((void)),
- check_error __P((char *)),
+ check_error __P((const char *)),
parse_args __P((int c, char *v[]));
static int replace_cmd __P((void));
static void
-usage(msg)
- char *msg;
+usage(const char *msg)
{
fprintf(stderr, "%s: usage error: %s\n", ProgramName, msg);
fprintf(stderr, "usage:\t%s [-u user] file\n", ProgramName);
@@ -87,9 +86,7 @@
int
-main(argc, argv)
- int argc;
- char *argv[];
+main(int argc, char **argv)
{
int exitstatus;
@@ -137,16 +134,14 @@
}
#if DEBUGGING
-char *getoptarg = "u:lerx:";
+const char *getoptarg = "u:lerx:";
#else
-char *getoptarg = "u:ler";
+const char *getoptarg = "u:ler";
#endif
static void
-parse_args(argc, argv)
- int argc;
- char *argv[];
+parse_args(int argc, char **argv)
{
int argch;
@@ -262,7 +257,7 @@
static void
-list_cmd() {
+list_cmd(void) {
char n[MAX_FNAME];
FILE *f;
int ch;
@@ -315,7 +310,7 @@
static void
-delete_cmd() {
+delete_cmd(void) {
char n[MAX_FNAME];
log_it(RealUser, Pid, "DELETE", User);
@@ -332,8 +327,7 @@
static void
-check_error(msg)
- char *msg;
+check_error(const char *msg)
{
CheckErrorCount++;
fprintf(stderr, "\"%s\":%d: %s\n", Filename, LineNumber-1, msg);
@@ -341,8 +335,9 @@
static void
-edit_cmd() {
- char n[MAX_FNAME], q[MAX_TEMPSTR], *editor;
+edit_cmd(void) {
+ char n[MAX_FNAME], q[MAX_TEMPSTR];
+ const char *editor;
FILE *f;
int ch, t, x;
struct stat statbuf;
@@ -569,7 +564,7 @@
* -2 on install error
*/
static int
-replace_cmd() {
+replace_cmd(void) {
char n[MAX_FNAME], envstr[MAX_ENVSTR], tn[MAX_FNAME];
FILE *tmp;
int ch, eof;
@@ -688,7 +683,7 @@
static void
-poke_daemon() {
+poke_daemon(void) {
#ifdef USE_UTIMES
struct timeval tvs[2];
struct timezone tz;
diff -ur cron-3.0pl1.orig/database.c cron-3.0pl1/database.c
--- cron-3.0pl1.orig/database.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/database.c Thu Nov 16 19:46:19 2000
@@ -44,16 +44,16 @@
#endif /* ifndef PATH_MAX */
-static void process_crontab __P((char *, char *, char *,
+static void process_crontab __P((const char *, const char *,
+ const char *,
struct stat *,
cron_db *, cron_db *));
#ifdef DEBIAN
-static int valid_name (char *filename);
+static int valid_name (const char *filename);
static user *get_next_system_crontab __P((user *));
#endif
void
-load_database(old_db)
- cron_db *old_db;
+load_database(cron_db *old_db)
{
DIR *dir;
struct stat statbuf;
@@ -257,9 +257,7 @@
void
-link_user(db, u)
- cron_db *db;
- user *u;
+link_user(cron_db *db, user *u)
{
if (db->head == NULL)
db->head = u;
@@ -272,9 +270,7 @@
void
-unlink_user(db, u)
- cron_db *db;
- user *u;
+unlink_user(cron_db *db, user *u)
{
if (u->prev == NULL)
db->head = u->next;
@@ -289,11 +285,9 @@
user *
-find_user(db, name)
- cron_db *db;
- char *name;
+find_user(cron_db *db, const char *name)
{
- char *env_get();
+ char *env_get(const char *name, char **envp);
user *u;
for (u = db->head; u != NULL; u = u->next)
@@ -304,13 +298,7 @@
static void
-process_crontab(uname, fname, tabname, statbuf, new_db, old_db)
- char *uname;
- char *fname;
- char *tabname;
- struct stat *statbuf;
- cron_db *new_db;
- cron_db *old_db;
+process_crontab(const char *uname, const char *fname, const char *tabname, struct stat *statbuf, cron_db *new_db, cron_db *old_db)
{
struct passwd *pw = NULL;
int crontab_fd = OK - 1;
@@ -405,7 +393,7 @@
#else
#include
/* Same function, better compliance with ISO C */
-static int valid_name (char *filename)
+static int valid_name (const char *filename)
{
while (*filename) {
if (!(isalnum(*filename) ||
@@ -420,8 +408,7 @@
#endif
static user *
-get_next_system_crontab (curtab)
- user *curtab;
+get_next_system_crontab (user *curtab)
{
for ( ; curtab != NULL; curtab = curtab->next)
if (!strncmp(curtab->name, "*system*", 8) && curtab->name [8])
diff -ur cron-3.0pl1.orig/debian/rules cron-3.0pl1/debian/rules
--- cron-3.0pl1.orig/debian/rules Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/debian/rules Thu Nov 16 18:41:36 2000
@@ -6,7 +6,7 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
-DEB_OPTIM= -O2 -Wall
+DEB_OPTIM= -O2 -Wall -pedantic
DEB_INSTALL = install
DEB_DEBUG_DEFS = -DDEBUGGING=0
diff -ur cron-3.0pl1.orig/do_command.c cron-3.0pl1/do_command.c
--- cron-3.0pl1.orig/do_command.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/do_command.c Thu Nov 16 19:21:56 2000
@@ -48,9 +48,7 @@
void
-do_command(e, u)
- entry *e;
- user *u;
+do_command(entry *e, user *u)
{
Debug(DPROC, ("[%d] do_command(%s, (%s,%d,%d))\n",
getpid(), e->cmd, u->name, e->uid, e->gid))
@@ -82,12 +80,10 @@
static void
-child_process(e, u)
- entry *e;
- user *u;
+child_process(entry *e, user *u)
{
int stdin_pipe[2], stdout_pipe[2];
- register char *input_data;
+ char *input_data;
char *usernm, *mailto;
int children = 0;
@@ -101,7 +97,7 @@
* our program name. This has no effect on some kernels.
*/
/*local*/{
- register char *pch;
+ char *pch;
for (pch = ProgramName; *pch; pch++)
*pch = MkUpper(*pch);
@@ -162,9 +158,9 @@
* If there are escaped %'s, remove the escape character.
*/
/*local*/{
- register int escaped = FALSE;
- register int ch;
- register char *p;
+ int escaped = FALSE;
+ int ch;
+ char *p;
for (input_data = p = e->cmd; (ch = *input_data);
input_data++, p++) {
@@ -337,10 +333,10 @@
*/
if (*input_data && fork() == 0) {
- register FILE *out = fdopen(stdin_pipe[WRITE_PIPE], "w");
- register int need_newline = FALSE;
- register int escaped = FALSE;
- register int ch;
+ FILE *out = fdopen(stdin_pipe[WRITE_PIPE], "w");
+ int need_newline = FALSE;
+ int escaped = FALSE;
+ int ch;
Debug(DPROC, ("[%d] child2 sending data to grandchild\n", getpid()))
@@ -399,12 +395,12 @@
Debug(DPROC, ("[%d] child reading output from grandchild\n", getpid()))
/*local*/{
- register FILE *in = fdopen(stdout_pipe[READ_PIPE], "r");
- register int ch = getc(in);
+ FILE *in = fdopen(stdout_pipe[READ_PIPE], "r");
+ int ch = getc(in);
if (ch != EOF) {
- register FILE *mail;
- register int bytes = 1;
+ FILE *mail;
+ int bytes = 1;
int status = 0;
Debug(DPROC|DEXT,
@@ -434,9 +430,9 @@
*/
if (mailto) {
- register char **env;
- auto char mailcmd[MAX_COMMAND];
- auto char hostname[MAXHOSTNAMELEN];
+ char **env;
+ char mailcmd[MAX_COMMAND];
+ char hostname[MAXHOSTNAMELEN];
(void) gethostname(hostname, MAXHOSTNAMELEN);
(void) snprintf(mailcmd, sizeof(mailcmd),
@@ -542,8 +538,7 @@
static void
-do_univ(u)
- user *u;
+do_univ(user *u)
{
#if defined(sequent)
/* Dynix (Sequent) hack to put the user associated with
diff -ur cron-3.0pl1.orig/entry.c cron-3.0pl1/entry.c
--- cron-3.0pl1.orig/entry.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/entry.c Fri Nov 17 15:24:57 2000
@@ -39,7 +39,7 @@
get_number __P((int *, int, char *[], int, FILE *));
static int set_element __P((bitstr_t *, int, int, int));
-static char *ecodes[] =
+static const char *ecodes[] =
{
"no error",
"bad minute",
@@ -54,8 +54,7 @@
void
-free_entry(e)
- entry *e;
+free_entry(entry *e)
{
free(e->cmd);
env_free(e->envp);
@@ -67,11 +66,7 @@
* otherwise return a pointer to a new entry.
*/
entry *
-load_entry(file, error_func, pw, envp)
- FILE *file;
- void (*error_func)();
- struct passwd *pw;
- char **envp;
+load_entry(FILE *file, void (*error_func) (/* ??? */), struct passwd *pw, char **envp)
{
/* this function reads one crontab entry -- the next -- from a file.
* it skips any leading blank lines, ignores comments, and returns
@@ -348,15 +343,15 @@
}
+/* bits: one bit per flag, default=FALSE */
+/* low, high: bounds, impl. offset for bitstr */
+/* names: NULL or *[] of names for these elements */
+/* ch: current character being processed */
+/* file: file being read */
static char
-get_list(bits, low, high, names, ch, file)
- bitstr_t *bits; /* one bit per flag, default=FALSE */
- int low, high; /* bounds, impl. offset for bitstr */
- char *names[]; /* NULL or *[] of names for these elements */
- int ch; /* current character being processed */
- FILE *file; /* file being read */
+get_list(bitstr_t *bits, int low, int high, char **names, int ch, FILE *file)
{
- register int done;
+ int done;
/* we know that we point to a non-blank character here;
* must do a Skip_Blanks before we exit, so that the
@@ -395,19 +390,19 @@
}
+/* bits: one bit per flag, default=FALSE */
+/* low, high: bounds, impl. offset for bitstr */
+/* names: NULL or names of elements */
+/* ch: current character being processed */
+/* file: file being read */
static char
-get_range(bits, low, high, names, ch, file)
- bitstr_t *bits; /* one bit per flag, default=FALSE */
- int low, high; /* bounds, impl. offset for bitstr */
- char *names[]; /* NULL or names of elements */
- int ch; /* current character being processed */
- FILE *file; /* file being read */
+get_range(bitstr_t *bits, int low, int high, char **names, int ch, FILE *file)
{
/* range = number | number "-" number [ "/" number ]
*/
- register int i;
- auto int num1, num2, num3;
+ int i;
+ int num1, num2, num3;
Debug(DPARS|DEXT, ("get_range()...entering, exit won't show\n"))
@@ -480,13 +475,13 @@
}
+/* numptr: where does the result go? */
+/* low: offset applied to result if symbolic enum used */
+/* names: symbolic names, if any, for enums */
+/* ch: current character */
+/* FILE: source */
static char
-get_number(numptr, low, names, ch, file)
- int *numptr; /* where does the result go? */
- int low; /* offset applied to result if symbolic enum used */
- char *names[]; /* symbolic names, if any, for enums */
- int ch; /* current character */
- FILE *file; /* source */
+get_number(int *numptr, int low, char **names, int ch, FILE *file)
{
char temp[MAX_TEMPSTR], *pc;
int len, i, all_digits;
@@ -535,12 +530,9 @@
}
+/* bits: one bit per flag, default=FALSE */
static int
-set_element(bits, low, high, number)
- bitstr_t *bits; /* one bit per flag, default=FALSE */
- int low;
- int high;
- int number;
+set_element(bitstr_t *bits, int low, int high, int number)
{
Debug(DPARS|DEXT, ("set_element(?,%d,%d,%d)\n", low, high, number))
diff -ur cron-3.0pl1.orig/env.c cron-3.0pl1/env.c
--- cron-3.0pl1.orig/env.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/env.c Thu Nov 16 19:33:20 2000
@@ -24,9 +24,9 @@
char **
-env_init()
+env_init(void)
{
- register char **p = (char **) malloc(sizeof(char **));
+ char **p = (char **) malloc(sizeof(char **));
if (p)
p[0] = NULL;
@@ -35,8 +35,7 @@
void
-env_free(envp)
- char **envp;
+env_free(char **envp)
{
char **p;
@@ -47,11 +46,10 @@
char **
-env_copy(envp)
- register char **envp;
+env_copy(char **envp)
{
- register int count, i;
- register char **p;
+ int count, i;
+ char **p;
for (count = 0; envp[count] != NULL; count++)
;
@@ -74,12 +72,10 @@
char **
-env_set(envp, envstr)
- char **envp;
- char *envstr;
+env_set(char **envp, char *envstr)
{
- register int count, found;
- register char **p;
+ int count, found;
+ char **p;
/*
* count the number of elements, including the null pointer;
@@ -131,9 +127,7 @@
* TRUE = was an env setting
*/
int
-load_env(envstr, f)
- char *envstr;
- FILE *f;
+load_env(char *envstr, FILE *f)
{
long filepos;
int fileline;
@@ -187,12 +181,10 @@
char *
-env_get(name, envp)
- register char *name;
- register char **envp;
+env_get(const char *name, char **envp)
{
- register int len = strlen(name);
- register char *p, *q;
+ int len = strlen(name);
+ char *p, *q;
while ((p = *envp++)) {
if (!(q = strchr(p, '=')))
diff -ur cron-3.0pl1.orig/job.c cron-3.0pl1/job.c
--- cron-3.0pl1.orig/job.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/job.c Thu Nov 16 18:37:20 2000
@@ -34,11 +34,9 @@
void
-job_add(e, u)
- register entry *e;
- register user *u;
+job_add(entry *e, user *u)
{
- register job *j;
+ job *j;
/* if already on queue, keep going */
for (j=jhead; j; j=j->next)
@@ -59,10 +57,10 @@
int
-job_runqueue()
+job_runqueue(void)
{
- register job *j, *jn;
- register int run = 0;
+ job *j, *jn;
+ int run = 0;
for (j=jhead; j; j=jn) {
do_command(j->e, j->u);
diff -ur cron-3.0pl1.orig/misc.c cron-3.0pl1/misc.c
--- cron-3.0pl1.orig/misc.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/misc.c Thu Nov 16 19:54:43 2000
@@ -49,12 +49,9 @@
int
-strcmp_until(left, right, until)
- char *left;
- char *right;
- int until;
+strcmp_until(const char *left, const char *right, int until)
{
- register int diff;
+ int diff;
while (*left && *left != until && *left == *right) {
left++;
@@ -75,8 +72,7 @@
/* strdtb(s) - delete trailing blanks in string 's' and return new length
*/
int
-strdtb(s)
- char *s;
+strdtb(char *s)
{
char *x = s;
@@ -104,8 +100,7 @@
int
-set_debug_flags(flags)
- char *flags;
+set_debug_flags(char *flags)
{
/* debug flags are of the form flag[,flag ...]
*
@@ -171,7 +166,7 @@
void
-set_cron_uid()
+set_cron_uid(void)
{
#if defined(BSD) || defined(POSIX)
if (seteuid(ROOT_UID) < OK) {
@@ -188,7 +183,7 @@
void
-set_cron_cwd()
+set_cron_cwd(void)
{
struct stat sb;
@@ -247,8 +242,7 @@
* it would be great if fflush() disassociated the file buffer.
*/
void
-acquire_daemonlock(closeflag)
- int closeflag;
+acquire_daemonlock(int closeflag)
{
static FILE *fp = NULL;
@@ -303,8 +297,7 @@
/* get_char(file) : like getc() but increment LineNumber on newlines
*/
int
-get_char(file)
- FILE *file;
+get_char(FILE *file)
{
int ch;
@@ -318,9 +311,7 @@
/* unget_char(ch, file) : like ungetc but do LineNumber processing
*/
void
-unget_char(ch, file)
- int ch;
- FILE *file;
+unget_char(int ch, FILE *file)
{
ungetc(ch, file);
if (ch == '\n')
@@ -335,11 +326,7 @@
* (4) returns EOF or terminating character, whichever
*/
int
-get_string(string, size, file, terms)
- char *string;
- int size;
- FILE *file;
- char *terms;
+get_string(char *string, int size, FILE *file, const char *terms)
{
int ch;
@@ -360,8 +347,7 @@
/* skip_comments(file) : read past comment (if any)
*/
void
-skip_comments(file)
- FILE *file;
+skip_comments(FILE *file)
{
int ch;
@@ -397,14 +383,12 @@
}
-/* int in_file(char *string, FILE *file)
+/* int in_file(const char *string, FILE *file)
* return TRUE if one of the lines in file matches string exactly,
* FALSE otherwise.
*/
static int
-in_file(string, file)
- char *string;
- FILE *file;
+in_file(const char *string, FILE *file)
{
char line[MAX_TEMPSTR];
@@ -425,8 +409,7 @@
* or (neither file exists but user=="root" so it's okay)
*/
int
-allowed(username)
- char *username;
+allowed(const char *username)
{
static int init = FALSE;
static FILE *allow, *deny;
@@ -475,17 +458,13 @@
#endif /* SYSLOG */
void
-log_it(username, xpid, event, detail)
- char *username;
- int xpid;
- char *event;
- char *detail;
+log_it(const char *username, int xpid, const char *event, const char *detail)
{
#if defined(LOG_FILE)
PID_T pid = xpid;
char *msg;
TIME_T now = time((TIME_T) 0);
- register struct tm *t = localtime(&now);
+ struct tm *t = localtime(&now);
int msg_size;
#endif /*LOG_FILE*/
@@ -602,7 +581,7 @@
void
-log_close() {
+log_close(void) {
#if defined(LOG_FILE)
if (LogFD != ERR) {
close(LogFD);
@@ -620,14 +599,14 @@
* (1) this routine is fairly slow
* (2) it returns a pointer to static storage
*/
+/* s: string we want the first word of */
+/* t: terminators, implicitly including \0 */
char *
-first_word(s, t)
- register char *s; /* string we want the first word of */
- register char *t; /* terminators, implicitly including \0 */
+first_word(const char *s, const char *t)
{
static char retbuf[2][MAX_TEMPSTR + 1]; /* sure wish C had GC */
static int retsel = 0;
- register char *rb, *rp;
+ char *rb, *rp;
/* select a return buffer */
retsel = 1-retsel;
@@ -654,14 +633,11 @@
* heavily ascii-dependent.
*/
void
-mkprint(dst, src, len)
- register char *dst;
- register unsigned char *src;
- register int len;
+mkprint(char *dst, const unsigned char *src, int len)
{
while (len-- > 0)
{
- register unsigned char ch = *src++;
+ unsigned char ch = *src++;
if (ch < ' ') { /* control character */
*dst++ = '^';
@@ -686,11 +662,9 @@
* returns a pointer to malloc'd storage, you must call free yourself.
*/
char *
-mkprints(src, len)
- register unsigned char *src;
- register unsigned int len;
+mkprints(const unsigned char *src, unsigned int len)
{
- register char *dst = malloc(len*4 + 1);
+ char *dst = malloc(len*4 + 1);
if (dst)
mkprint(dst, src, len);
@@ -704,8 +678,7 @@
* 1234567890123456789012345678901234567
*/
char *
-arpadate(clock)
- time_t *clock;
+arpadate(time_t *clock)
{
static char ret[64]; /* zone name might be >3 chars */
time_t t = clock ? *clock : time(NULL);
@@ -740,6 +713,6 @@
int swap_uids() { save_euid = geteuid(); return seteuid(getuid()); }
int swap_uids_back() { return seteuid(save_euid); }
#else /*HAVE_SAVED_UIDS*/
-int swap_uids() { return setreuid(geteuid(), getuid()); }
-int swap_uids_back() { return swap_uids(); }
+int swap_uids(void) { return setreuid(geteuid(), getuid()); }
+int swap_uids_back(void) { return swap_uids(); }
#endif /*HAVE_SAVED_UIDS*/
diff -ur cron-3.0pl1.orig/popen.c cron-3.0pl1/popen.c
--- cron-3.0pl1.orig/popen.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/popen.c Thu Nov 16 18:37:21 2000
@@ -48,11 +48,9 @@
static int fds;
FILE *
-cron_popen(program, type, e)
- char *program, *type;
- entry *e;
+cron_popen(char *program, char *type, entry *e)
{
- register char *cp;
+ char *cp;
FILE *iop;
int argc, pdes[2];
PID_T pid;
@@ -156,10 +154,9 @@
}
int
-cron_pclose(iop)
- FILE *iop;
+cron_pclose(FILE *iop)
{
- register int fdes;
+ int fdes;
int omask;
WAIT_T stat_loc;
PID_T pid;
diff -ur cron-3.0pl1.orig/user.c cron-3.0pl1/user.c
--- cron-3.0pl1.orig/user.c Thu Nov 16 19:58:36 2000
+++ cron-3.0pl1/user.c Thu Nov 16 19:29:41 2000
@@ -27,8 +27,7 @@
void
-free_user(u)
- user *u;
+free_user(user *u)
{
entry *e, *ne;
@@ -42,10 +41,10 @@
user *
-load_user(crontab_fd, pw, name)
- int crontab_fd;
- struct passwd *pw; /* NULL implies syscrontab */
- char *name;
+load_user(int crontab_fd, struct passwd *pw, const char *name)
+
+ /* NULL implies syscrontab */
+
{
char envstr[MAX_ENVSTR];
FILE *file;
Tags added: patch
Request was from Javier Fernández-Sanguino Peña <jfs@computer.org>
to control@bugs.debian.org.
Received: (at control) by bugs.debian.org; 5 Jul 2005 22:03:06 +0000
From jfs@dat.etsit.upm.es Tue Jul 05 15:03:06 2005
Return-path:
Received: from tornado.dat.etsit.upm.es (dat.etsit.upm.es) [138.100.17.73]
by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
id 1DpvVR-0005Tf-00; Tue, 05 Jul 2005 15:03:05 -0700
Received: (qmail 7500 invoked by uid 1013); 5 Jul 2005 22:03:02 -0000
Date: Wed, 6 Jul 2005 00:03:02 +0200
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?=
To: control@bugs.debian.org
Subject: Adjusting bugs
Message-ID: <20050705220302.GA31896@dat.etsit.upm.es>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh"
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
Delivered-To: control@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=BAYES_00,VALID_BTS_CONTROL
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--jI8keyz6grp/JLjh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
tag 30655 patch
tag 15258 patch
tag 77313 patch
tag 271747 patch
merge 117758 289636
thanks
--jI8keyz6grp/JLjh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCywOWi4sehJTrj0oRAozfAKCUXIIojaznESE6Wct6Z62Rw78TeQCeLFXG
cB4pjJFzEHrvyg98TKlTQcA=
=hUd3
-----END PGP SIGNATURE-----
--jI8keyz6grp/JLjh--
Message sent on to Normal User <gohmandj@mrs.umn.edu>:
Bug#77313.
Normal User
X-Loop: owner@bugs.debian.org
Subject: Bug#77313: this bug/#77313 - cron: misc source cleanups
Reply-To: Justin Pryzby , 77313-quiet@bugs.debian.org
Resent-To: Normal User
Resent-Date: Sun, 16 Mar 2008 21:00:13 +0000
Resent-Message-ID:
Resent-Sender: owner@bugs.debian.org
X-Debian-PR-Message: report 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Received: via spool by 77313-submitter@bugs.debian.org id=U77313.12057010687787
(code U ref 77313); Sun, 16 Mar 2008 21:00:13 +0000
Received: (at 77313-submitter) by bugs.debian.org; 16 Mar 2008 20:57:48 +0000
X-Spam-Checker-Version: SpamAssassin 3.1.4-bugs.debian.org_2005_01_02
(2006-07-26) on rietz.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-3.7 required=4.0 tests=BAYES_00,DNS_FROM_RFC_ABUSE,
FOURLA autolearn=no version=3.1.4-bugs.debian.org_2005_01_02
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1JazvQ-0001zl-5x
for 77313-submitter@bugs.debian.org; Sun, 16 Mar 2008 20:57:48 +0000
Received: from libra ([74.71.209.227]) by hrndva-omta02.mail.rr.com
with ESMTP
id <20080316205742.KQNI21550.hrndva-omta02.mail.rr.com@libra>
for <77313-submitter@bugs.debian.org>;
Sun, 16 Mar 2008 20:57:42 +0000
Received: from pryzbyj by libra with local (Exim 4.63)
(envelope-from )
id 1JazvJ-0002l0-RL
for 77313-submitter@bugs.debian.org; Sun, 16 Mar 2008 16:57:41 -0400
Date: Sun, 16 Mar 2008 16:57:41 -0400
From: Justin Pryzby
To: 77313-submitter@bugs.debian.org
Message-ID: <20080316205741.GA10566@libra>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
#77313 - cron: misc source cleanups
http://bugs.debian.org./77313
FWIW the latest upstream cron release from ISC (not yet packaged for
Debian) changes to ANSI prototypes and drops some (but not all) use of
"register".
Received: (at 77313-submitter) by bugs.debian.org; 16 Mar 2008 20:57:48 +0000
From justinpryzby@users.sourceforge.net Sun Mar 16 20:57:48 2008
X-Spam-Checker-Version: SpamAssassin 3.1.4-bugs.debian.org_2005_01_02
(2006-07-26) on rietz.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-3.7 required=4.0 tests=BAYES_00,DNS_FROM_RFC_ABUSE,
FOURLA autolearn=no version=3.1.4-bugs.debian.org_2005_01_02
Return-path:
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1JazvQ-0001zl-5x
for 77313-submitter@bugs.debian.org; Sun, 16 Mar 2008 20:57:48 +0000
Received: from libra ([74.71.209.227]) by hrndva-omta02.mail.rr.com
with ESMTP
id <20080316205742.KQNI21550.hrndva-omta02.mail.rr.com@libra>
for <77313-submitter@bugs.debian.org>;
Sun, 16 Mar 2008 20:57:42 +0000
Received: from pryzbyj by libra with local (Exim 4.63)
(envelope-from )
id 1JazvJ-0002l0-RL
for 77313-submitter@bugs.debian.org; Sun, 16 Mar 2008 16:57:41 -0400
Date: Sun, 16 Mar 2008 16:57:41 -0400
From: Justin Pryzby
To: 77313-submitter@bugs.debian.org
Subject: this bug/#77313 - cron: misc source cleanups
Message-ID: <20080316205741.GA10566@libra>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
#77313 - cron: misc source cleanups
http://bugs.debian.org./77313
FWIW the latest upstream cron release from ISC (not yet packaged for
Debian) changes to ANSI prototypes and drops some (but not all) use of
"register".
Information forwarded
to debian-bugs-dist@lists.debian.org, Javier Fernandez-Sanguino Pen~a <jfs@computer.org>:
Bug#77313; Package cron.
debian-bugs-dist@lists.debian.orgJavier Fernandez-Sanguino Pen~a
X-Loop: owner@bugs.debian.org
Subject: Bug#77313: URL to cron src
Reply-To: Tomas Pospisek , 77313@bugs.debian.org
Resent-From: Tomas Pospisek
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Javier Fernandez-Sanguino Pen~a
Resent-Date: Thu, 08 Jan 2009 12:45:01 +0000
Resent-Message-ID:
Resent-Sender: owner@bugs.debian.org
X-Debian-PR-Message: followup 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Received: via spool by 77313-submit@bugs.debian.org id=B77313.123141853320935
(code B ref 77313); Thu, 08 Jan 2009 12:45:01 +0000
Received: (at 77313) by bugs.debian.org; 8 Jan 2009 12:42:13 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 43; hammy, 85; neutral, 39; spammy, 0.
spammytokens: hammytokens:0.000-+--H*c:PLAIN, 0.000-+--cron, 0.000-+--ANSI,
0.000-+--H*u:Alpine, 0.000-+--H*UA:Alpine
X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00,FOURLA
autolearn=no version=3.2.3-bugs.debian.org_2005_01_02
Received: from mail05.solnet.ch ([212.101.4.139])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LKuDF-0005RP-5v
for 77313@bugs.debian.org; Thu, 08 Jan 2009 12:42:13 +0000
X-Virus-Scanned: by SolNet-Check at mail05.solnet.ch
Received: from mail05.solnet.ch ([127.0.0.1])
by localhost (mail05.solnet.ch [127.0.0.1]) (SolNet-Check, port 10024)
with LMTP id g9BjAczC0ve7 for <77313@bugs.debian.org>;
Thu, 8 Jan 2009 12:42:10 +0000 (UTC)
Received: from [10.0.1.3] (212-41-92-44.adsl.solnet.ch [212.41.92.44])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by mail05.solnet.ch (Postfix) with ESMTPS id E9FF43F407
for <77313@bugs.debian.org>; Thu, 8 Jan 2009 12:42:09 +0000 (UTC)
Date: Thu, 8 Jan 2009 13:42:03 +0100 (CET)
From: Tomas Pospisek
X-X-Sender: tpo@tpo-laptop
To: 77313@bugs.debian.org
Message-ID:
User-Agent: Alpine 1.00 (DEB 882 2007-12-20)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Justin Pryzby wrote on Sun, 16 Mar 2008:
> #77313 - cron: misc source cleanups
> http://bugs.debian.org./77313
>
> FWIW the latest upstream cron release from ISC (not yet packaged for
> Debian) changes to ANSI prototypes and drops some (but not all) use of
> "register".
The "latest" upstream release, cron 4.1 seems to be available here:
ftp://ftp.isc.org/isc/cron/
and was released on 2004/01/23.
Is there any available discussion on why Debian has never packaged the new
release? Everybody else seems to package 4.1.
?
*t
Acknowledgement sent
to Tomas Pospisek <tpo@sourcepole.ch>:
Extra info received and forwarded to list. Copy sent to Javier Fernandez-Sanguino Pen~a <jfs@computer.org>.
-t
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.420 (Entity 5.420)
Content-Type: text/plain; charset=utf-8
X-Loop: owner@bugs.debian.org
From: owner@bugs.debian.org (Debian Bug Tracking System)
To: Tomas Pospisek
Subject: Bug#77313: Info received (URL to cron src)
Message-ID:
References:
X-Debian-PR-Message: ack-info 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Reply-To: 77313@bugs.debian.org
Date: Thu, 08 Jan 2009 12:45:02 +0000
Thank you for the additional information you have supplied regarding
this Bug report.
This is an automatically generated reply to let you know your message
has been received.
Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.
Your message has been sent to the package maintainer(s):
Javier Fernandez-Sanguino Pen~a
If you wish to submit further information on this problem, please
send it to 77313@bugs.debian.org, as before.
Please do not send mail to owner@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.
--=20
77313: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D77313
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
Received: (at 77313) by bugs.debian.org; 8 Jan 2009 12:42:13 +0000
From tpo@sourcepole.ch Thu Jan 08 12:42:13 2009
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 43; hammy, 85; neutral, 39; spammy, 0.
spammytokens: hammytokens:0.000-+--H*c:PLAIN, 0.000-+--cron, 0.000-+--ANSI,
0.000-+--H*u:Alpine, 0.000-+--H*UA:Alpine
X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00,FOURLA
autolearn=no version=3.2.3-bugs.debian.org_2005_01_02
Return-path:
Received: from mail05.solnet.ch ([212.101.4.139])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LKuDF-0005RP-5v
for 77313@bugs.debian.org; Thu, 08 Jan 2009 12:42:13 +0000
X-Virus-Scanned: by SolNet-Check at mail05.solnet.ch
Received: from mail05.solnet.ch ([127.0.0.1])
by localhost (mail05.solnet.ch [127.0.0.1]) (SolNet-Check, port 10024)
with LMTP id g9BjAczC0ve7 for <77313@bugs.debian.org>;
Thu, 8 Jan 2009 12:42:10 +0000 (UTC)
Received: from [10.0.1.3] (212-41-92-44.adsl.solnet.ch [212.41.92.44])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by mail05.solnet.ch (Postfix) with ESMTPS id E9FF43F407
for <77313@bugs.debian.org>; Thu, 8 Jan 2009 12:42:09 +0000 (UTC)
Date: Thu, 8 Jan 2009 13:42:03 +0100 (CET)
From: Tomas Pospisek
X-X-Sender: tpo@tpo-laptop
To: 77313@bugs.debian.org
Subject: URL to cron src
Message-ID:
User-Agent: Alpine 1.00 (DEB 882 2007-12-20)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Justin Pryzby wrote on Sun, 16 Mar 2008:
> #77313 - cron: misc source cleanups
> http://bugs.debian.org./77313
>
> FWIW the latest upstream cron release from ISC (not yet packaged for
> Debian) changes to ANSI prototypes and drops some (but not all) use of
> "register".
The "latest" upstream release, cron 4.1 seems to be available here:
ftp://ftp.isc.org/isc/cron/
and was released on 2004/01/23.
Is there any available discussion on why Debian has never packaged the new
release? Everybody else seems to package 4.1.
?
*t
Information forwarded
to debian-bugs-dist@lists.debian.org, Javier Fernandez-Sanguino Pen~a <jfs@computer.org>:
Bug#77313; Package cron.
debian-bugs-dist@lists.debian.orgJavier Fernandez-Sanguino Pen~a
X-Loop: owner@bugs.debian.org
Subject: Bug#77313: URL to cron src
Reply-To: "Javier Fernandez-Sanguino" , 77313@bugs.debian.org
Resent-From: "Javier Fernandez-Sanguino"
Original-Sender: javifs@gmail.com
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Javier Fernandez-Sanguino Pen~a
Resent-Date: Thu, 08 Jan 2009 14:21:01 +0000
Resent-Message-ID:
Resent-Sender: owner@bugs.debian.org
X-Debian-PR-Message: followup 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Received: via spool by 77313-submit@bugs.debian.org id=B77313.123142437330844
(code B ref 77313); Thu, 08 Jan 2009 14:21:01 +0000
Received: (at 77313) by bugs.debian.org; 8 Jan 2009 14:19:33 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 27; hammy, 87; neutral, 35; spammy, 3.
spammytokens:0.983-+--Our, 0.914-+--our, 0.852-+--UD:com
hammytokens:0.000-+--cron, 0.000-+--H*f:sk:alpine., 0.000-+--H*MI:sk:alpine.,
0.000-+--H*i:sk:alpine., 0.000-+--HDomainKey-Signature:references
X-Spam-Status: No, score=-7.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
MURPHY_DRUGS_REL8,SPF_PASS autolearn=ham
version=3.2.3-bugs.debian.org_2005_01_02
Received: from mail-fx0-f27.google.com ([209.85.220.27])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LKvjR-0007zF-Ez
for 77313@bugs.debian.org; Thu, 08 Jan 2009 14:19:33 +0000
Received: by fxm8 with SMTP id 8so1720675fxm.17
for <77313@bugs.debian.org>; Thu, 08 Jan 2009 06:19:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=domainkey-signature:received:received:message-id:date:from:sender
:to:subject:in-reply-to:mime-version:content-type
:content-transfer-encoding:content-disposition:references
:x-google-sender-auth;
bh=IOZ8sB7lRql3P27UU0MMybqa/9PtK3q8QJnQzZuLex0=;
b=WXNZoYCEp2MoT3K/qOLMTRU31IgtYEU1k5VGGNxSZtNX/PjKiN7kj/HlRq9MkqDGih
ZJWOsNtvXis1iAMzshCCFTgIWAyuVxsfzHrwqxHRMBTqXKcq184rVXkleAKcgKpwhbP1
qmv8Kklwsk2BN+MX7UR7j9IuM0zy8tGs31np0=
DomainKey-Signature: a=rsa-sha1; c=nofws;
d=gmail.com; s=gamma;
h=message-id:date:from:sender:to:subject:in-reply-to:mime-version
:content-type:content-transfer-encoding:content-disposition
:references:x-google-sender-auth;
b=xA56jhdzxdDr49DeKivUaW357CYw4QsVFAuF9+JxV3NDAqMviUBTYgxYKkyX8RINul
Wwyk1EtjhiTe4y9WB5GuGQ67IiP/WfpX7QwRFJOPUqPC/ICyybKZZrSseaMZB4ZDoL/3
3aIqNBMePdBTOIjdY1OthHgnkoA0nIKvtqYg4=
Received: by 10.181.218.14 with SMTP id v14mr9336564bkq.111.1231424367075;
Thu, 08 Jan 2009 06:19:27 -0800 (PST)
Received: by 10.180.206.9 with HTTP; Thu, 8 Jan 2009 06:19:27 -0800 (PST)
Message-ID:
Date: Thu, 8 Jan 2009 15:19:27 +0100
From: "Javier Fernandez-Sanguino"
Sender: javifs@gmail.com
To: "Tomas Pospisek" , 77313@bugs.debian.org
In-Reply-To:
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References:
X-Google-Sender-Auth: 790bbf271d5d1557
> Is there any available discussion on why Debian has never packaged the new
> release? Everybody else seems to package 4.1.
There has not been enougth help to forward all our patches to the 4.1
release. Our cron version is heavily patched and moving to this
release requires a lot of time and testing.
Help with doing this would be appreciated.
Regards
Javier
Acknowledgement sent
to "Javier Fernandez-Sanguino" <jfs@computer.org>:
Extra info received and forwarded to list. Copy sent to Javier Fernandez-Sanguino Pen~a <jfs@computer.org>.
-t
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.420 (Entity 5.420)
Content-Type: text/plain; charset=utf-8
X-Loop: owner@bugs.debian.org
From: owner@bugs.debian.org (Debian Bug Tracking System)
To: "Javier Fernandez-Sanguino"
Subject: Bug#77313: Info received (Bug#77313: URL to cron src)
Message-ID:
References:
X-Debian-PR-Message: ack-info 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Reply-To: 77313@bugs.debian.org
Date: Thu, 08 Jan 2009 14:21:02 +0000
Thank you for the additional information you have supplied regarding
this Bug report.
This is an automatically generated reply to let you know your message
has been received.
Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.
Your message has been sent to the package maintainer(s):
Javier Fernandez-Sanguino Pen~a
If you wish to submit further information on this problem, please
send it to 77313@bugs.debian.org, as before.
Please do not send mail to owner@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.
--=20
77313: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D77313
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
Received: (at 77313) by bugs.debian.org; 8 Jan 2009 14:19:33 +0000
From javifs@gmail.com Thu Jan 08 14:19:33 2009
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 27; hammy, 87; neutral, 35; spammy, 3.
spammytokens:0.983-+--Our, 0.914-+--our, 0.852-+--UD:com
hammytokens:0.000-+--cron, 0.000-+--H*f:sk:alpine., 0.000-+--H*MI:sk:alpine.,
0.000-+--H*i:sk:alpine., 0.000-+--HDomainKey-Signature:references
X-Spam-Status: No, score=-7.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
MURPHY_DRUGS_REL8,SPF_PASS autolearn=ham
version=3.2.3-bugs.debian.org_2005_01_02
Return-path:
Received: from mail-fx0-f27.google.com ([209.85.220.27])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LKvjR-0007zF-Ez
for 77313@bugs.debian.org; Thu, 08 Jan 2009 14:19:33 +0000
Received: by fxm8 with SMTP id 8so1720675fxm.17
for <77313@bugs.debian.org>; Thu, 08 Jan 2009 06:19:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=domainkey-signature:received:received:message-id:date:from:sender
:to:subject:in-reply-to:mime-version:content-type
:content-transfer-encoding:content-disposition:references
:x-google-sender-auth;
bh=IOZ8sB7lRql3P27UU0MMybqa/9PtK3q8QJnQzZuLex0=;
b=WXNZoYCEp2MoT3K/qOLMTRU31IgtYEU1k5VGGNxSZtNX/PjKiN7kj/HlRq9MkqDGih
ZJWOsNtvXis1iAMzshCCFTgIWAyuVxsfzHrwqxHRMBTqXKcq184rVXkleAKcgKpwhbP1
qmv8Kklwsk2BN+MX7UR7j9IuM0zy8tGs31np0=
DomainKey-Signature: a=rsa-sha1; c=nofws;
d=gmail.com; s=gamma;
h=message-id:date:from:sender:to:subject:in-reply-to:mime-version
:content-type:content-transfer-encoding:content-disposition
:references:x-google-sender-auth;
b=xA56jhdzxdDr49DeKivUaW357CYw4QsVFAuF9+JxV3NDAqMviUBTYgxYKkyX8RINul
Wwyk1EtjhiTe4y9WB5GuGQ67IiP/WfpX7QwRFJOPUqPC/ICyybKZZrSseaMZB4ZDoL/3
3aIqNBMePdBTOIjdY1OthHgnkoA0nIKvtqYg4=
Received: by 10.181.218.14 with SMTP id v14mr9336564bkq.111.1231424367075;
Thu, 08 Jan 2009 06:19:27 -0800 (PST)
Received: by 10.180.206.9 with HTTP; Thu, 8 Jan 2009 06:19:27 -0800 (PST)
Message-ID:
Date: Thu, 8 Jan 2009 15:19:27 +0100
From: "Javier Fernandez-Sanguino"
Sender: javifs@gmail.com
To: "Tomas Pospisek" , 77313@bugs.debian.org
Subject: Re: Bug#77313: URL to cron src
In-Reply-To:
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References:
X-Google-Sender-Auth: 790bbf271d5d1557
> Is there any available discussion on why Debian has never packaged the new
> release? Everybody else seems to package 4.1.
There has not been enougth help to forward all our patches to the 4.1
release. Our cron version is heavily patched and moving to this
release requires a lot of time and testing.
Help with doing this would be appreciated.
Regards
Javier
Information forwarded
to debian-bugs-dist@lists.debian.org, Javier Fernandez-Sanguino Pen~a <jfs@computer.org>:
Bug#77313; Package cron.
debian-bugs-dist@lists.debian.orgJavier Fernandez-Sanguino Pen~a
X-Loop: owner@bugs.debian.org
Subject: Bug#77313: URL to cron src
Reply-To: Tomas Pospisek , 77313@bugs.debian.org
Resent-From: Tomas Pospisek
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Javier Fernandez-Sanguino Pen~a
Resent-Date: Thu, 08 Jan 2009 14:45:01 +0000
Resent-Message-ID:
Resent-Sender: owner@bugs.debian.org
X-Debian-PR-Message: followup 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Received: via spool by 77313-submit@bugs.debian.org id=B77313.123142569219035
(code B ref 77313); Thu, 08 Jan 2009 14:45:01 +0000
Received: (at 77313) by bugs.debian.org; 8 Jan 2009 14:41:32 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 36; hammy, 111; neutral, 44; spammy,
2. spammytokens:0.983-+--Our, 0.914-+--our hammytokens:0.000-+--H*c:PLAIN,
0.000-+--cron, 0.000-+--SVN, 0.000-+--Hcc:D*org, 0.000-+--debians
X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER,
MURPHY_DRUGS_REL8,SPF_HELO_PASS autolearn=ham
version=3.2.3-bugs.debian.org_2005_01_02
Received: from mail04.solnet.ch ([212.101.4.138])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LKw4i-0004w9-7p
for 77313@bugs.debian.org; Thu, 08 Jan 2009 14:41:32 +0000
X-Virus-Scanned: by SolNet-Check at mail04.solnet.ch
Received: from mail04.solnet.ch ([127.0.0.1])
by localhost (mail04.solnet.ch [127.0.0.1]) (SolNet-Check, port 10024)
with LMTP id 4z5TDMTKwVHM; Thu, 8 Jan 2009 14:40:54 +0000 (UTC)
Received: from [10.0.1.3] (212-41-92-44.adsl.solnet.ch [212.41.92.44])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by mail04.solnet.ch (Postfix) with ESMTPS id B84CA86727;
Thu, 8 Jan 2009 14:40:44 +0000 (UTC)
Date: Thu, 8 Jan 2009 15:40:45 +0100 (CET)
From: Tomas Pospisek
X-X-Sender: tpo@tpo-laptop
To: Javier Fernandez-Sanguino
cc: 77313@bugs.debian.org
In-Reply-To:
Message-ID:
References:
User-Agent: Alpine 1.00 (DEB 882 2007-12-20)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Thu, 8 Jan 2009, Javier Fernandez-Sanguino wrote:
>> Is there any available discussion on why Debian has never packaged the new
>> release? Everybody else seems to package 4.1.
>
> There has not been enougth help to forward all our patches to the 4.1
> release. Our cron version is heavily patched and moving to this
> release requires a lot of time and testing.
>
> Help with doing this would be appreciated.
Does Debian's cron live in a RCS of some sort? What would be useful in
porting forward Debian's patches is being able to extract individual
patch sets together with the rationale of them - as in SVN or in
debian/patches/* or similar.
Is it correct that none of those things exists and thus one would have to
run through and interdiff all individual Debian releases since the
beginning of the packaging in 1996?
*t
Acknowledgement sent
to Tomas Pospisek <tpo@sourcepole.ch>:
Extra info received and forwarded to list. Copy sent to Javier Fernandez-Sanguino Pen~a <jfs@computer.org>.
-t
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.420 (Entity 5.420)
Content-Type: text/plain; charset=utf-8
X-Loop: owner@bugs.debian.org
From: owner@bugs.debian.org (Debian Bug Tracking System)
To: Tomas Pospisek
Subject: Bug#77313: Info received (Bug#77313: URL to cron src)
Message-ID:
References:
X-Debian-PR-Message: ack-info 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Reply-To: 77313@bugs.debian.org
Date: Thu, 08 Jan 2009 14:45:02 +0000
Thank you for the additional information you have supplied regarding
this Bug report.
This is an automatically generated reply to let you know your message
has been received.
Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.
Your message has been sent to the package maintainer(s):
Javier Fernandez-Sanguino Pen~a
If you wish to submit further information on this problem, please
send it to 77313@bugs.debian.org, as before.
Please do not send mail to owner@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.
--=20
77313: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D77313
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
Received: (at 77313) by bugs.debian.org; 8 Jan 2009 14:41:32 +0000
From tpo@sourcepole.ch Thu Jan 08 14:41:32 2009
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 36; hammy, 111; neutral, 44; spammy,
2. spammytokens:0.983-+--Our, 0.914-+--our hammytokens:0.000-+--H*c:PLAIN,
0.000-+--cron, 0.000-+--SVN, 0.000-+--Hcc:D*org, 0.000-+--debians
X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER,
MURPHY_DRUGS_REL8,SPF_HELO_PASS autolearn=ham
version=3.2.3-bugs.debian.org_2005_01_02
Return-path:
Received: from mail04.solnet.ch ([212.101.4.138])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LKw4i-0004w9-7p
for 77313@bugs.debian.org; Thu, 08 Jan 2009 14:41:32 +0000
X-Virus-Scanned: by SolNet-Check at mail04.solnet.ch
Received: from mail04.solnet.ch ([127.0.0.1])
by localhost (mail04.solnet.ch [127.0.0.1]) (SolNet-Check, port 10024)
with LMTP id 4z5TDMTKwVHM; Thu, 8 Jan 2009 14:40:54 +0000 (UTC)
Received: from [10.0.1.3] (212-41-92-44.adsl.solnet.ch [212.41.92.44])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by mail04.solnet.ch (Postfix) with ESMTPS id B84CA86727;
Thu, 8 Jan 2009 14:40:44 +0000 (UTC)
Date: Thu, 8 Jan 2009 15:40:45 +0100 (CET)
From: Tomas Pospisek
X-X-Sender: tpo@tpo-laptop
To: Javier Fernandez-Sanguino
cc: 77313@bugs.debian.org
Subject: Re: Bug#77313: URL to cron src
In-Reply-To:
Message-ID:
References:
User-Agent: Alpine 1.00 (DEB 882 2007-12-20)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Thu, 8 Jan 2009, Javier Fernandez-Sanguino wrote:
>> Is there any available discussion on why Debian has never packaged the new
>> release? Everybody else seems to package 4.1.
>
> There has not been enougth help to forward all our patches to the 4.1
> release. Our cron version is heavily patched and moving to this
> release requires a lot of time and testing.
>
> Help with doing this would be appreciated.
Does Debian's cron live in a RCS of some sort? What would be useful in
porting forward Debian's patches is being able to extract individual
patch sets together with the rationale of them - as in SVN or in
debian/patches/* or similar.
Is it correct that none of those things exists and thus one would have to
run through and interdiff all individual Debian releases since the
beginning of the packaging in 1996?
*t
Information forwarded
to debian-bugs-dist@lists.debian.org, Javier Fernandez-Sanguino Pen~a <jfs@computer.org>:
Bug#77313; Package cron.
debian-bugs-dist@lists.debian.orgJavier Fernandez-Sanguino Pen~a
X-Loop: owner@bugs.debian.org
Subject: Bug#77313: URL to cron src
Reply-To: Javier =?UTF-8?Q?Fern=C3=A1ndez-Sanguino_?= =?UTF-8?Q?Pe=C3=B1a?= , 77313@bugs.debian.org
Resent-From: Javier =?UTF-8?Q?Fern=C3=A1ndez-Sanguino_?= =?UTF-8?Q?Pe=C3=B1a?=
Original-Sender: Javier Fernandez-Sanguino
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Javier Fernandez-Sanguino Pen~a
Resent-Date: Fri, 09 Jan 2009 13:30:02 +0000
Resent-Message-ID:
Resent-Sender: owner@bugs.debian.org
X-Debian-PR-Message: followup 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Received: via spool by 77313-submit@bugs.debian.org id=B77313.123150778015059
(code B ref 77313); Fri, 09 Jan 2009 13:30:02 +0000
Received: (at 77313) by bugs.debian.org; 9 Jan 2009 13:29:40 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 28; hammy, 150; neutral, 57; spammy,
1. spammytokens:0.983-+--Our hammytokens:0.000-+--cron, 0.000-+--SVN,
0.000-+--H*UA:1.5.18, 0.000-+--H*u:1.5.18, 0.000-+--H*UA:2008-05-17
X-Spam-Status: No, score=-6.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER,
MURPHY_DRUGS_REL8,SPF_PASS autolearn=ham
version=3.2.3-bugs.debian.org_2005_01_02
Received: from mail-bw0-f18.google.com ([209.85.218.18])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LLHQh-0003tq-Tg
for 77313@bugs.debian.org; Fri, 09 Jan 2009 13:29:40 +0000
Received: by bwz11 with SMTP id 11so867709bwz.17
for <77313@bugs.debian.org>; Fri, 09 Jan 2009 05:29:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=domainkey-signature:received:received:sender:received:date:from:to
:cc:subject:message-id:mail-followup-to:references:mime-version
:content-type:content-disposition:in-reply-to:user-agent;
bh=wUDFpF96ottUOHWyF7o8rFa0/qZQsfZYGzuBK32fSS4=;
b=oeTFH8zMZVFKtHpunKkC6WWqlG+uYkUGPH0oCMO7alH1tnT3gozkVj/bTPfqiIGSTV
Ts5puuYklfxHH+gmrkwIdQ6yQZqJsUoFllMnVk34O8gyx3FlOSWwVzXWr7P1BfsxhNcw
n+ZdAqYiCY0j/gVXZSePvvpclD3H/BZsNGGww=
DomainKey-Signature: a=rsa-sha1; c=nofws;
d=gmail.com; s=gamma;
h=sender:date:from:to:cc:subject:message-id:mail-followup-to
:references:mime-version:content-type:content-disposition
:in-reply-to:user-agent;
b=euuH4DLGGV10A0ThcjETydPVodr9brkzn1IK5/g+zcIHv2qT8pGD9hlD/Q1EoxLkud
L0Ul0CvURFSZAZO9IxkJyynKP2ymaTbiyZ175uLK/G/TorzU83x3qcprSs9SOJqoRK1L
5TneiYxsrk7DAFb2iow6+KiH55DM5M0YS5GlM=
Received: by 10.103.11.5 with SMTP id o5mr9186409mui.75.1231507678707;
Fri, 09 Jan 2009 05:27:58 -0800 (PST)
Received: from javifsp.no-ip.org ([84.78.35.59])
by mx.google.com with ESMTPS id y2sm35252438mug.14.2009.01.09.05.27.57
(version=TLSv1/SSLv3 cipher=RC4-MD5);
Fri, 09 Jan 2009 05:27:57 -0800 (PST)
Sender: Javier Fernandez-Sanguino
Received: from jfs by javifsp.no-ip.org with local (Exim 4.69)
(envelope-from )
id 1LLHP1-00051l-Hp; Fri, 09 Jan 2009 14:27:55 +0100
Date: Fri, 9 Jan 2009 14:27:55 +0100
From: Javier =?UTF-8?Q?Fern=C3=A1ndez-Sanguino_?= =?UTF-8?Q?Pe=C3=B1a?=
To: Tomas Pospisek
Cc: 77313@bugs.debian.org
Message-ID: <20090109132755.GA19217@javifsp.no-ip.org>
Mail-Followup-To: Tomas Pospisek , 77313@bugs.debian.org
References:
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To:
User-Agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jan 08, 2009 at 03:40:45PM +0100, Tomas Pospisek wrote:
> On Thu, 8 Jan 2009, Javier Fernandez-Sanguino wrote:
>
>>> Is there any available discussion on why Debian has never packaged the new
>>> release? Everybody else seems to package 4.1.
>>
>> There has not been enougth help to forward all our patches to the 4.1
>> release. Our cron version is heavily patched and moving to this
>> release requires a lot of time and testing.
>>
>> Help with doing this would be appreciated.
>
> Does Debian's cron live in a RCS of some sort? What would be useful in
> porting forward Debian's patches is being able to extract individual
> patch sets together with the rationale of them - as in SVN or in
> debian/patches/* or similar.
The cron package is maintained through Alioth, please take a look at
svn://svn.debian.org/pkg-cron/
or
http://svn.debian.org/wsvn/pkg-cron
Regards
Javier
Acknowledgement sent
to Javier Fernández-Sanguino Peña <jfs@computer.org>:
Extra info received and forwarded to list. Copy sent to Javier Fernandez-Sanguino Pen~a <jfs@computer.org>.
-t
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.420 (Entity 5.420)
Content-Type: text/plain; charset=utf-8
X-Loop: owner@bugs.debian.org
From: owner@bugs.debian.org (Debian Bug Tracking System)
To: Javier =?UTF-8?Q?Fern=C3=A1ndez-Sanguino_?= =?UTF-8?Q?Pe=C3=B1a?=
Subject: Bug#77313: Info received (Bug#77313: URL to cron src)
Message-ID:
References: <20090109132755.GA19217@javifsp.no-ip.org>
X-Debian-PR-Message: ack-info 77313
X-Debian-PR-Package: cron
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: cron
Reply-To: 77313@bugs.debian.org
Date: Fri, 09 Jan 2009 13:30:03 +0000
Thank you for the additional information you have supplied regarding
this Bug report.
This is an automatically generated reply to let you know your message
has been received.
Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.
Your message has been sent to the package maintainer(s):
Javier Fernandez-Sanguino Pen~a
If you wish to submit further information on this problem, please
send it to 77313@bugs.debian.org, as before.
Please do not send mail to owner@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.
--=20
77313: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D77313
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
Received: (at 77313) by bugs.debian.org; 9 Jan 2009 13:29:40 +0000
From javifs@gmail.com Fri Jan 09 13:29:40 2009
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
(2007-08-08) on rietz.debian.org
X-Spam-Level:
X-Spam-Bayes: score:0.0000 Tokens: new, 28; hammy, 150; neutral, 57; spammy,
1. spammytokens:0.983-+--Our hammytokens:0.000-+--cron, 0.000-+--SVN,
0.000-+--H*UA:1.5.18, 0.000-+--H*u:1.5.18, 0.000-+--H*UA:2008-05-17
X-Spam-Status: No, score=-6.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER,
MURPHY_DRUGS_REL8,SPF_PASS autolearn=ham
version=3.2.3-bugs.debian.org_2005_01_02
Return-path:
Received: from mail-bw0-f18.google.com ([209.85.218.18])
by rietz.debian.org with esmtp (Exim 4.63)
(envelope-from )
id 1LLHQh-0003tq-Tg
for 77313@bugs.debian.org; Fri, 09 Jan 2009 13:29:40 +0000
Received: by bwz11 with SMTP id 11so867709bwz.17
for <77313@bugs.debian.org>; Fri, 09 Jan 2009 05:29:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=domainkey-signature:received:received:sender:received:date:from:to
:cc:subject:message-id:mail-followup-to:references:mime-version
:content-type:content-disposition:in-reply-to:user-agent;
bh=wUDFpF96ottUOHWyF7o8rFa0/qZQsfZYGzuBK32fSS4=;
b=oeTFH8zMZVFKtHpunKkC6WWqlG+uYkUGPH0oCMO7alH1tnT3gozkVj/bTPfqiIGSTV
Ts5puuYklfxHH+gmrkwIdQ6yQZqJsUoFllMnVk34O8gyx3FlOSWwVzXWr7P1BfsxhNcw
n+ZdAqYiCY0j/gVXZSePvvpclD3H/BZsNGGww=
DomainKey-Signature: a=rsa-sha1; c=nofws;
d=gmail.com; s=gamma;
h=sender:date:from:to:cc:subject:message-id:mail-followup-to
:references:mime-version:content-type:content-disposition
:in-reply-to:user-agent;
b=euuH4DLGGV10A0ThcjETydPVodr9brkzn1IK5/g+zcIHv2qT8pGD9hlD/Q1EoxLkud
L0Ul0CvURFSZAZO9IxkJyynKP2ymaTbiyZ175uLK/G/TorzU83x3qcprSs9SOJqoRK1L
5TneiYxsrk7DAFb2iow6+KiH55DM5M0YS5GlM=
Received: by 10.103.11.5 with SMTP id o5mr9186409mui.75.1231507678707;
Fri, 09 Jan 2009 05:27:58 -0800 (PST)
Received: from javifsp.no-ip.org ([84.78.35.59])
by mx.google.com with ESMTPS id y2sm35252438mug.14.2009.01.09.05.27.57
(version=TLSv1/SSLv3 cipher=RC4-MD5);
Fri, 09 Jan 2009 05:27:57 -0800 (PST)
Sender: Javier Fernandez-Sanguino
Received: from jfs by javifsp.no-ip.org with local (Exim 4.69)
(envelope-from )
id 1LLHP1-00051l-Hp; Fri, 09 Jan 2009 14:27:55 +0100
Date: Fri, 9 Jan 2009 14:27:55 +0100
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?=
To: Tomas Pospisek
Cc: 77313@bugs.debian.org
Subject: Re: Bug#77313: URL to cron src
Message-ID: <20090109132755.GA19217@javifsp.no-ip.org>
Mail-Followup-To: Tomas Pospisek , 77313@bugs.debian.org
References:
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To:
User-Agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jan 08, 2009 at 03:40:45PM +0100, Tomas Pospisek wrote:
> On Thu, 8 Jan 2009, Javier Fernandez-Sanguino wrote:
>
>>> Is there any available discussion on why Debian has never packaged the new
>>> release? Everybody else seems to package 4.1.
>>
>> There has not been enougth help to forward all our patches to the 4.1
>> release. Our cron version is heavily patched and moving to this
>> release requires a lot of time and testing.
>>
>> Help with doing this would be appreciated.
>
> Does Debian's cron live in a RCS of some sort? What would be useful in
> porting forward Debian's patches is being able to extract individual
> patch sets together with the rationale of them - as in SVN or in
> debian/patches/* or similar.
The cron package is maintained through Alioth, please take a look at
svn://svn.debian.org/pkg-cron/
or
http://svn.debian.org/wsvn/pkg-cron
Regards
Javier